Skip to content

Add CAPTCHA for ticket submission#799

Merged
apolignano merged 2 commits into
devfrom
ticket_security
May 22, 2026
Merged

Add CAPTCHA for ticket submission#799
apolignano merged 2 commits into
devfrom
ticket_security

Conversation

@apolignano
Copy link
Copy Markdown
Contributor

@apolignano apolignano commented May 18, 2026

This PR addresses https://embl.atlassian.net/browse/IBU-12438.

An HCaptcha React component now shows up on the feedback page. If validated, the submit button appears.

To address:

  • I'm the one who created the HCaptcha account. It might be worth discussing how to have that account registered under a team/group email.

@apolignano apolignano requested a review from matthiasblum May 18, 2026 13:48
@apolignano
Copy link
Copy Markdown
Contributor Author

hCaptcha group-level account created.

Copy link
Copy Markdown
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, with one thing that needs to be changed.

At first, I ran the API and the client on my laptop, without being connected to the VPN (MySQL and Elastic connections going through SSH tunnels). Not being on the EBI network, the email failed to be sent to smtp.ebi.ac.uk: the following block raised an exception:

https://github.com/ProteinsWebTeam/interpro7-api/blob/2a78f22bea7353eb2db8e5d6ab6d7cd9db50944b/webfront/views/mail.py#L39-L46

Since it's not caught, the API returns a 500 and an "Invalid request" callout is displayed:

setFeedbackText('Invalid request');
setFeedbackType('warning');

Would it be possible to show an more informative error message, e.g.

Sorry, we couldn't send your feedback. You can submit it through our contact form instead. Please mention that you encountered a sending error.

@apolignano apolignano requested a review from matthiasblum May 22, 2026 14:56
Copy link
Copy Markdown
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@apolignano apolignano merged commit ee906e9 into dev May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants