Fix #113 serve-d being stuck in endless loop

DCD serverPipes code rewritten by webfreak

Author: ryuukk

source/workspaced/api.d

@@ -106,7 +106,10 @@ mixin template DefaultComponentWrapper(bool withDtor = true)
 			if (!_threads)
 				synchronized (this)
 					if (!_threads)
+					{
 						_threads = new TaskPool(max(minSize, min(maxSize, defaultPoolThreads)));
+						_threads.isDaemon = true;
+					}
 			return _threads;
 		}
 

source/workspaced/backend.d

@@ -623,7 +623,10 @@ class WorkspaceD
 		if (!_gthreads)
 			synchronized (this)
 				if (!_gthreads)
+				{
 					_gthreads = new TaskPool(max(2, min(6, defaultPoolThreads)));
+					_gthreads.isDaemon = true;
+				}
 		return _gthreads;
 	}
 }

source/workspaced/com/dcd.d

@@ -227,16 +227,28 @@ class DCDComponent : ComponentWrapper
 		running = true;
 		serverThreads.create({
 			mixin(traceTask);
-			if (quietServer)
-				foreach (block; serverPipes.stderr.byChunk(4096))
-				{
-				}
-			else
-				while (serverPipes.stderr.isOpen && !serverPipes.stderr.eof)
-				{
-					auto line = serverPipes.stderr.readln();
-					trace("Server: ", line); // evaluates lazily, so read before
-				}
+			scope (exit)
+				running = false;
+
+			try
+			{
+				if (quietServer)
+					foreach (block; serverPipes.stderr.byChunk(4096))
+					{
+					}
+				else
+					while (serverPipes.stderr.isOpen && !serverPipes.stderr.eof)
+					{
+						auto line = serverPipes.stderr.readln();
+						trace("Server: ", line); // evaluates lazily, so read before
+					}
+			}
+			catch (Exception e)
+			{
+				error("Reading/clearing stderr from dcd-server crashed (-> killing dcd-server): ", e);
+				serverPipes.pid.kill();
+			}
+
 			auto code = serverPipes.pid.wait();
 			info("DCD-Server stopped with code ", code);
 			if (code != 0)
@@ -246,7 +258,6 @@ class DCDComponent : ComponentWrapper
 						"type": JSONValue("crash"),
 						"component": JSONValue("dcd")
 					]));
-				running = false;
 			}
 		});
 	}