Skip to content

Add support for 64-bit indexing on transpose kernels - #10549

Closed
eng-flavio-teixeira wants to merge 9 commits into
ROCm:developfrom
eng-flavio-teixeira:kernel_offsets
Closed

Add support for 64-bit indexing on transpose kernels#10549
eng-flavio-teixeira wants to merge 9 commits into
ROCm:developfrom
eng-flavio-teixeira:kernel_offsets

Conversation

@eng-flavio-teixeira

Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.66667% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
projects/rocfft/library/src/include/rtc_kernel.h 58.49% 11 Missing and 11 partials ⚠️
projects/rocfft/library/src/tree_node_rtc.cpp 76.47% 3 Missing and 1 partial ⚠️
projects/rocfft/library/src/rtc_transpose_gen.cpp 96.55% 1 Missing ⚠️
...ojects/rocfft/library/src/rtc_transpose_kernel.cpp 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10549      +/-   ##
===========================================
- Coverage    68.90%   68.85%   -0.04%     
===========================================
  Files         2766     2767       +1     
  Lines       455507   455562      +55     
  Branches     67142    67165      +23     
===========================================
- Hits        313828   313668     -160     
- Misses      118765   118980     +215     
  Partials     22914    22914              
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.07% <ø> (ø) Carriedforward from c4a1de3
TensileLite-Unit 75.93% <ø> (ø) Carriedforward from c4a1de3
hipBLAS 90.62% <ø> (ø) Carriedforward from c4a1de3
hipBLASLt 34.89% <ø> (ø) Carriedforward from c4a1de3
hipCUB 82.68% <ø> (ø) Carriedforward from c4a1de3
hipDNN 86.53% <ø> (ø) Carriedforward from c4a1de3
hipFFT 45.76% <ø> (ø) Carriedforward from c4a1de3
hipRAND 76.12% <ø> (ø) Carriedforward from c4a1de3
hipSOLVER 69.03% <ø> (ø) Carriedforward from c4a1de3
hipSPARSE 86.99% <ø> (ø) Carriedforward from c4a1de3
rocBLAS 48.23% <ø> (ø) Carriedforward from c4a1de3
rocFFT 47.55% <76.67%> (-0.57%) ⬇️
rocRAND 57.02% <ø> (ø) Carriedforward from c4a1de3
rocSOLVER 76.92% <ø> (ø) Carriedforward from c4a1de3
rocSPARSE 72.55% <ø> (ø) Carriedforward from c4a1de3
rocThrust 91.60% <ø> (ø) Carriedforward from c4a1de3

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../rocfft/library/src/include/rtc_transpose_kernel.h 100.00% <100.00%> (ø)
projects/rocfft/library/src/include/tree_node.h 40.51% <ø> (ø)
projects/rocfft/shared/fft_params.h 5.15% <ø> (+0.05%) ⬆️
projects/rocfft/library/src/rtc_transpose_gen.cpp 72.28% <96.55%> (-11.11%) ⬇️
...ojects/rocfft/library/src/rtc_transpose_kernel.cpp 88.60% <95.00%> (-1.58%) ⬇️
projects/rocfft/library/src/tree_node_rtc.cpp 76.47% <76.47%> (ø)
projects/rocfft/library/src/include/rtc_kernel.h 78.80% <58.49%> (-6.69%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eng-flavio-teixeira
eng-flavio-teixeira deleted the kernel_offsets branch August 11, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant