fix: use BUILD_INTERFACE to prevent header target dependency propagation (#738)

nullccxsy · nullccxsy · web-flow · commit 058adc78d0c8 · 2025-10-05T13:52:47.000-04:00
Wrap roaring-headers and roaring-headers-cpp targets in generator expressions
to prevent these internal targets from being propagated to installed packages,
improving CMake package compatibility.

Co-authored-by: nullccxsy &lt;32149055912@qq.com&gt;
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -59,8 +59,9 @@ if(ROARING_DISABLE_NEON)
   target_compile_definitions(roaring PUBLIC DISABLENEON=1)
 endif(ROARING_DISABLE_NEON)
 
-target_link_libraries(roaring PUBLIC roaring-headers)
-target_link_libraries(roaring PUBLIC roaring-headers-cpp)
+target_link_libraries(roaring PUBLIC "$<BUILD_INTERFACE:roaring-headers>")
+target_link_libraries(roaring PUBLIC "$<BUILD_INTERFACE:roaring-headers-cpp>")
+
 #
 #install(TARGETS roaring DESTINATION lib)
 #

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,9 @@ if(ROARING_DISABLE_NEON)`
`59`	`59`	`target_compile_definitions(roaring PUBLIC DISABLENEON=1)`
`60`	`60`	`endif(ROARING_DISABLE_NEON)`
`61`	`61`
`62`		`-target_link_libraries(roaring PUBLIC roaring-headers)`
`63`		`-target_link_libraries(roaring PUBLIC roaring-headers-cpp)`
	`62`	`+target_link_libraries(roaring PUBLIC "$<BUILD_INTERFACE:roaring-headers>")`
	`63`	`+target_link_libraries(roaring PUBLIC "$<BUILD_INTERFACE:roaring-headers-cpp>")`
	`64`	`+`
`64`	`65`	`#`
`65`	`66`	`#install(TARGETS roaring DESTINATION lib)`
`66`	`67`	`#`