perf: speed up roaring_bitmap_remove (#699)

Dr-Emann · web-flow · commit fd520e1d60e3 · 2025-03-14T11:40:33.000-04:00
container_nonzero_cardinality has to do less work for bitset/run
containers than calculating the full cardinality.
diff --git a/src/roaring.c b/src/roaring.c
@@ -614,7 +614,7 @@ void roaring_bitmap_remove(roaring_bitmap_t *r, uint32_t val) {
             ra_set_container_at_index(&r->high_low_container, i, container2,
                                       newtypecode);
         }
-        if (container_get_cardinality(container2, newtypecode) != 0) {
+        if (container_nonzero_cardinality(container2, newtypecode)) {
             ra_set_container_at_index(&r->high_low_container, i, container2,
                                       newtypecode);
         } else {

Original file line number	Diff line number	Diff line change
`@@ -614,7 +614,7 @@ void roaring_bitmap_remove(roaring_bitmap_t *r, uint32_t val) {`
`614`	`614`	`ra_set_container_at_index(&r->high_low_container, i, container2,`
`615`	`615`	`newtypecode);`
`616`	`616`	`}`
`617`		`- if (container_get_cardinality(container2, newtypecode) != 0) {`
	`617`	`+ if (container_nonzero_cardinality(container2, newtypecode)) {`
`618`	`618`	`ra_set_container_at_index(&r->high_low_container, i, container2,`
`619`	`619`	`newtypecode);`
`620`	`620`	`} else {`