-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
bugSomething isn't workingSomething isn't workinggithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions code
Description
Test results are effectively ignored because of the configuration of CI/CD workflows.
Presently, the workflow responsible for running the tests is dotted with
continue-on-error: truewhich allows the workflow to continue even if the step fails (at least the step where continue-on-error: true was set).
Additionally, flake8 is run as
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statisticswhere --exit-zero causes flake8 to terminate without error, despite the presence of linting errors in the code.
Suggestion
- Remove
continue-on-error: trueeverywhere except where its presence makes sense, (coveralls.io test coverage reporting only, most likely). - Remove
--exit-zerofrom flake8
Unfortunately, these changes will cause CI/CD to fail—but they will do so correctly with the desired behavior, rather than silently allowing failing code to pass.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions code