fix(diffusion_gemma): init preempt-rebuild runtime fields in init_multi_block#46
Conversation
…ti_block DiffusionGemmaReq overrides init_multi_block without calling super(), so base DllmReq fields _resume_prefill_until and _terminal_context_block_id were never set. lazy_activate() then raised AttributeError on the first step(), breaking diffusion_gemma_gsm8k benchmark runs. Fixes SJTU-DENG-Lab#45
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo instance fields, ChangesBug Fix: Missing fields in
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
_resume_prefill_untiland_terminal_context_block_idinDiffusionGemmaReq.init_multi_block().DiffusionGemmaReqoverridesinit_multi_blockwithout callingsuper(), so after the preempt-rebuild changes in baseDllmReq(609b593), these runtime fields were never set.AttributeErroron the firststep()→lazy_activate()when running the DiffusionGemma GSM8K benchmark.Fixes #45
Summary by CodeRabbit