Skip to content

[java] assert setFiles uploads reach the server in SetFilesCommandTest - #18058

Open
yashp676 wants to merge 1 commit into
SeleniumHQ:trunkfrom
yashp676:java-setfiles-upload-roundtrip
Open

yashp676 wants to merge 1 commit into
SeleniumHQ:trunkfrom
yashp676:java-setfiles-upload-roundtrip

Conversation

@yashp676

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds two round-trip tests to SetFilesCommandTest. The existing four only check
that the input's value ends with the filename, which doesn't prove the file was
uploaded. The new ones submit the form and check what the upload endpoint echoed
back into the iframe, the same way UploadTest does.

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added C-java Java Bindings B-devtools Includes everything BiDi or Chrome DevTools related labels Sep 20, 2026
@yashp676

Copy link
Copy Markdown
Contributor Author

@pujagani would you have time to look at this? @titusfortner pointed me your way for Java BiDi. #18025 is also open if the UploadHandler parsing change is in your area — happy to split it differently if the two would be easier to review separately.

@yashp676

yashp676 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Hi @diemol and @titusfortner now that #18025 has been merged, this is the follow-up from #18010: two round-trip tests in SetFilesCommandTest that submit the form and assert the uploaded contents reach the server, the same way UploadTest does. It's test-only, 80 lines in one file.Could one of you take a look when you have a moment? Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-devtools Includes everything BiDi or Chrome DevTools related C-java Java Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants