Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
@pujagani would you have time to look at this? @titusfortner pointed me your way for Java BiDi. #18025 is also open if the UploadHandler parsing change is in your area — happy to split it differently if the two would be easier to review separately. |
|
Hi @diemol and @titusfortner now that #18025 has been merged, this is the follow-up from #18010: two round-trip tests in SetFilesCommandTest that submit the form and assert the uploaded contents reach the server, the same way UploadTest does. It's test-only, 80 lines in one file.Could one of you take a look when you have a moment? Thanks! |
What does this PR do?
Adds two round-trip tests to
SetFilesCommandTest. The existing four only checkthat the input's
valueends with the filename, which doesn't prove the file wasuploaded. The new ones submit the form and check what the upload endpoint echoed
back into the iframe, the same way
UploadTestdoes.