Skip to content

Migration guide mentions offline_access_token_expires, but the supported key appears to be expiring_offline_access_tokens #2074

Description

@AckermannTM

Overview/summary

While following the migration guide for expiring offline access tokens, I noticed a documentation inconsistency.

In docs/shopify_app/sessions.md, the ShopifyAPI::Context.setup example uses expiring_offline_access_tokens: true, but later in the same guide it also mentions offline_access_token_expires: true.

I could not find support for offline_access_token_expires in either shopify_app or shopify_api. The supported key appears to be expiring_offline_access_tokens.

The same offline_access_token_expires naming also appears in CHANGELOG.md, which makes it unclear which configuration key is actually valid.

Metadata

Metadata

Assignees

No one assigned

    Labels

    devtools-gardenerPost the issue or PR to Slack for the gardener

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions