don't eagerly construct the format string when calling replaceWith (sorbet#8423)

froydnj · web-flow · commit 64525f1f81cb · 2025-01-07T09:34:12.000-08:00
diff --git a/core/types/types.cc b/core/types/types.cc
@@ -945,7 +945,7 @@ TypePtr Types::unwrapType(const GlobalState &gs, Loc loc, const TypePtr &tp) {
                                    "T.unsafe");
                     auto locSource = loc.source(gs);
                     if (locSource.has_value()) {
-                        e.replaceWith("Wrap in `T.unsafe`", loc, fmt::format("T.unsafe({})", locSource.value()));
+                        e.replaceWith("Wrap in `T.unsafe`", loc, "T.unsafe({})", locSource.value());
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -945,7 +945,7 @@ TypePtr Types::unwrapType(const GlobalState &gs, Loc loc, const TypePtr &tp) {`
`945`	`945`	`"T.unsafe");`
`946`	`946`	`auto locSource = loc.source(gs);`
`947`	`947`	`if (locSource.has_value()) {`
`948`		- e.replaceWith("Wrap in `T.unsafe`", loc, fmt::format("T.unsafe({})", locSource.value()));
	`948`	+ e.replaceWith("Wrap in `T.unsafe`", loc, "T.unsafe({})", locSource.value());
`949`	`949`	`}`
`950`	`950`	`}`
`951`	`951`	`}`