Skip to content

Commit 16c4403

Browse files
committed
Remove remote-ui references from Admin surface
Add version string into registration call
1 parent fd4dd2b commit 16c4403

File tree

90 files changed

+364
-604
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

90 files changed

+364
-604
lines changed

.changeset/pretty-terms-switch.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@shopify/ui-extensions-react': minor
3+
'@shopify/ui-extensions': minor
4+
---
5+
6+
Support remote-dom for Admin surface

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
"@shopify/loom-plugin-eslint": "^2.0.0",
4848
"@shopify/loom-plugin-prettier": "^2.0.0",
4949
"@shopify/typescript-configs": "^5.1.0",
50+
"@rollup/plugin-replace": "^6.0.1",
5051
"eslint": "^8.28.0",
5152
"nodemon": "^2.0.4",
5253
"prettier": "^2.8.0",

packages/ui-extensions-react/package.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,23 @@
6363
"dependencies": {
6464
"@remote-ui/async-subscription": "^2.1.12",
6565
"@remote-ui/react": "^5.0.2",
66-
"@types/react": ">=18.2.67"
66+
"@types/react": ">=18.2.67",
67+
"@types/react-dom": ">=18.2.67"
6768
},
6869
"peerDependencies": {
6970
"@shopify/ui-extensions": "0.0.0-unstable",
70-
"react": ">=18.0.0"
71+
"react": ">=18.0.0",
72+
"react-dom": ">=18.0.0"
7173
},
7274
"peerDependenciesMeta": {
7375
"@shopify/ui-extensions": {
7476
"optional": false
7577
},
7678
"react": {
7779
"optional": false
80+
},
81+
"react-dom": {
82+
"optional": false
7883
}
7984
},
8085
"devDependencies": {
Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
1-
import {AdminAction as BaseAdminAction} from '@shopify/ui-extensions/admin';
2-
import {
3-
createRemoteReactComponent,
4-
ReactPropsFromRemoteComponentType,
5-
} from '@remote-ui/react';
1+
import {createRemoteComponent} from '../util';
62

7-
export const AdminAction = createRemoteReactComponent(BaseAdminAction, {
8-
fragmentProps: ['primaryAction', 'secondaryAction'],
9-
});
3+
export type {AdminActionProps} from '@shopify/ui-extensions/admin';
104

11-
export type AdminActionProps = ReactPropsFromRemoteComponentType<
12-
typeof BaseAdminAction
13-
>;
5+
export const AdminAction = createRemoteComponent('ui-admin-action');
Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
1-
import {AdminBlock as BaseAdminBlock} from '@shopify/ui-extensions/admin';
2-
import {
3-
createRemoteReactComponent,
4-
ReactPropsFromRemoteComponentType,
5-
} from '@remote-ui/react';
1+
import {createRemoteComponent} from '../util';
62

7-
export const AdminBlock = createRemoteReactComponent(BaseAdminBlock);
3+
export type {AdminBlockProps} from '@shopify/ui-extensions/admin';
84

9-
export type AdminBlockProps = ReactPropsFromRemoteComponentType<
10-
typeof BaseAdminBlock
11-
>;
5+
export const AdminBlock = createRemoteComponent('ui-admin-block');
Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,5 @@
1-
import {AdminPrintAction as BaseAdminPrintAction} from '@shopify/ui-extensions/admin';
2-
import {
3-
createRemoteReactComponent,
4-
ReactPropsFromRemoteComponentType,
5-
} from '@remote-ui/react';
1+
import {createRemoteComponent} from '../util';
62

7-
export const AdminPrintAction =
8-
createRemoteReactComponent(BaseAdminPrintAction);
3+
export type {AdminPrintActionProps} from '@shopify/ui-extensions/admin';
94

10-
export type AdminPrintActionProps = ReactPropsFromRemoteComponentType<
11-
typeof BaseAdminPrintAction
12-
>;
5+
export const AdminPrintAction = createRemoteComponent('ui-admin-print-action');
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import {Badge as BaseBadge} from '@shopify/ui-extensions/admin';
2-
import type {BadgeProps} from '@shopify/ui-extensions/admin';
3-
import {createRemoteReactComponent} from '@remote-ui/react';
1+
import {createRemoteComponent} from '../util';
42

5-
export const Badge = createRemoteReactComponent<'Badge', BadgeProps>(BaseBadge);
63
export type {BadgeProps} from '@shopify/ui-extensions/admin';
4+
5+
export const Badge = createRemoteComponent('ui-badge');
Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
1-
import {Banner as BaseBanner} from '@shopify/ui-extensions/admin';
2-
import {
3-
createRemoteReactComponent,
4-
ReactPropsFromRemoteComponentType,
5-
} from '@remote-ui/react';
1+
import {createRemoteComponent} from '../util';
62

7-
export const Banner = createRemoteReactComponent(BaseBanner, {
8-
fragmentProps: ['primaryAction', 'secondaryAction'],
9-
});
3+
export type {BannerProps} from '@shopify/ui-extensions/admin';
104

11-
export type BannerProps = ReactPropsFromRemoteComponentType<typeof BaseBanner>;
5+
export const Banner = createRemoteComponent('ui-banner');
Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
1-
import {BlockStack as BaseBlockStack} from '@shopify/ui-extensions/admin';
2-
import type {BlockStackProps} from '@shopify/ui-extensions/admin';
3-
import {createRemoteReactComponent} from '@remote-ui/react';
1+
import {createRemoteComponent} from '../util';
42

5-
export const BlockStack = createRemoteReactComponent<
6-
'BlockStack',
7-
BlockStackProps
8-
>(BaseBlockStack);
93
export type {BlockStackProps} from '@shopify/ui-extensions/admin';
4+
5+
export const BlockStack = createRemoteComponent('ui-block-stack');
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import {Box as BaseBox} from '@shopify/ui-extensions/admin';
2-
import type {BoxProps} from '@shopify/ui-extensions/admin';
3-
import {createRemoteReactComponent} from '@remote-ui/react';
1+
import {createRemoteComponent} from '../util';
42

5-
export const Box = createRemoteReactComponent<'Box', BoxProps>(BaseBox);
63
export type {BoxProps} from '@shopify/ui-extensions/admin';
4+
5+
export const Box = createRemoteComponent('ui-box');

0 commit comments

Comments
 (0)