Skip to content

Commit a5a8e47

Browse files
authored
Make preact and @preact/signals optional peer dependencies (#3400)
### Background Make `preact` and `@preact/signals` optional peer dependencies in the `@shopify/ui-extensions` package, allowing consumers to use the package without requiring these dependencies if they're not needed. Consumers should be able to pull in their own version explicitly. Previously these were set to `optionalDependencies` with `"*"` which resolved to the latest version. ### 🎩 Snapit is down so we cannot top hat 😥 ### Checklist - [ ] I have 🎩'd these changes - [ ] I have updated relevant documentation
2 parents f8f97d2 + c072113 commit a5a8e47

File tree

3 files changed

+30
-15
lines changed

3 files changed

+30
-15
lines changed

.changeset/eleven-moose-design.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/ui-extensions': patch
3+
---
4+
5+
Make preact and @preact/signals optional peer dependencies

packages/ui-extensions/package.json

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,22 @@
129129
"@remote-ui/async-subscription": "^2.1.16",
130130
"@shopify/generate-docs": "0.19.6",
131131
"typescript": "^4.9.0",
132-
"@faker-js/faker": "^8.4.1"
132+
"@faker-js/faker": "^8.4.1",
133+
"preact": "^10.10.x",
134+
"@preact/signals": "^2.3.x"
133135
},
134-
"optionalDependencies": {
136+
"peerDependencies": {
135137
"preact": "*",
136138
"@preact/signals": "*"
137139
},
140+
"peerDependenciesMeta": {
141+
"preact": {
142+
"optional": true
143+
},
144+
"@preact/signals": {
145+
"optional": true
146+
}
147+
},
138148
"publishConfig": {
139149
"access": "public",
140150
"@shopify:registry": "https://registry.npmjs.org/"

yarn.lock

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1773,17 +1773,17 @@
17731773
"@nodelib/fs.scandir" "2.1.5"
17741774
fastq "^1.6.0"
17751775

1776-
"@preact/signals-core@^1.7.0":
1777-
version "1.8.0"
1778-
resolved "https://registry.npmjs.org/@preact/signals-core/-/signals-core-1.8.0.tgz"
1779-
integrity sha512-OBvUsRZqNmjzCZXWLxkZfhcgT+Fk8DDcT/8vD6a1xhDemodyy87UJRJfASMuSD8FaAIeGgGm85ydXhm7lr4fyA==
1776+
"@preact/signals-core@^1.12.0":
1777+
version "1.12.1"
1778+
resolved "https://registry.yarnpkg.com/@preact/signals-core/-/signals-core-1.12.1.tgz#714b489bb35d9874cc44b35706a9dc27da8d21c4"
1779+
integrity sha512-BwbTXpj+9QutoZLQvbttRg5x3l5468qaV2kufh+51yha1c53ep5dY4kTuZR35+3pAZxpfQerGJiQqg34ZNZ6uA==
17801780

1781-
"@preact/signals@*":
1782-
version "2.0.2"
1783-
resolved "https://registry.npmjs.org/@preact/signals/-/signals-2.0.2.tgz"
1784-
integrity sha512-Qvu30QoIswaWXmFQZwzBc1CdyB+biIZCpHxoYcNplRTySLkCH6f7RMlHtwb0tmkfQJ+WBkUqR7ajPjdsc1Uq+w==
1781+
"@preact/signals@^2.3.x":
1782+
version "2.3.1"
1783+
resolved "https://registry.yarnpkg.com/@preact/signals/-/signals-2.3.1.tgz#91fde3ebf02794afa8d463fe1ccd5fda9509fe1d"
1784+
integrity sha512-nyuRIGmcwM/HjvFHhN2xUWfyla9D4llHt+prWoxjQfD6b5prO7CFPlG/xjJkP31Oic4KQXfH9SIhJFP9cy4lmg==
17851785
dependencies:
1786-
"@preact/signals-core" "^1.7.0"
1786+
"@preact/signals-core" "^1.12.0"
17871787

17881788
"@remote-ui/async-subscription@^2.1.16":
17891789
version "2.1.16"
@@ -5938,10 +5938,10 @@ possible-typed-array-names@^1.0.0:
59385938
resolved "https://registry.npmjs.org/possible-typed-array-names/-/possible-typed-array-names-1.0.0.tgz"
59395939
integrity sha512-d7Uw+eZoloe0EHDIYoe+bQ5WXnGMOpmiZFTuMWCwpjzzkL2nTjcKiAk4hh8TjnGye2TwWOk3UXucZ+3rbmBa8Q==
59405940

5941-
preact@*:
5942-
version "10.26.5"
5943-
resolved "https://registry.npmjs.org/preact/-/preact-10.26.5.tgz"
5944-
integrity sha512-fmpDkgfGU6JYux9teDWLhj9mKN55tyepwYbxHgQuIxbWQzgFg5vk7Mrrtfx7xRxq798ynkY4DDDxZr235Kk+4w==
5941+
preact@^10.10.x:
5942+
version "10.27.2"
5943+
resolved "https://registry.yarnpkg.com/preact/-/preact-10.27.2.tgz#19b9009c1be801a76a0aaf0fe5ba665985a09312"
5944+
integrity sha512-5SYSgFKSyhCbk6SrXyMpqjb5+MQBgfvEKE/OC+PujcY34sOpqtr+0AZQtPYx5IA6VxynQ7rUPCtKzyovpj9Bpg==
59455945

59465946
preferred-pm@^3.0.0:
59475947
version "3.1.3"

0 commit comments

Comments
 (0)