Skip to content

Commit df23cd0

Browse files
committed
Add aspectRatio comment to empty state examples
1 parent 5119500 commit df23cd0

File tree

4 files changed

+6
-41
lines changed

4 files changed

+6
-41
lines changed

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/emptyState.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<s-section accessibilityLabel="Empty state section">
22
<s-grid gap="base" justifyItems="center" paddingBlock="large-400">
33
<s-box maxInlineSize="200px" maxBlockSize="200px">
4+
<!-- aspectRatio should match the actual image dimensions (width/height) -->
45
<s-image
56
aspectRatio="1/0.5"
67
src="https://cdn.shopify.com/static/images/polaris/patterns/callout.png"

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/emptyState.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<s-section accessibilityLabel="Empty state section">
22
<s-grid gap="base" justifyItems="center" paddingBlock="large-400">
33
<s-box maxInlineSize="200px" maxBlockSize="200px">
4+
{/* aspectRatio should match the actual image dimensions (width/height) */}
45
<s-image
56
aspectRatio="1/0.5"
67
src="https://cdn.shopify.com/static/images/polaris/patterns/callout.png"
Lines changed: 3 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,3 @@
1-
<s-button commandFor="action-list">Action List</s-button>
2-
3-
<s-popover id="action-list">
4-
<s-stack direction="block">
5-
<s-stack paddingInline="small-100" paddingBlockStart="small-100"><s-heading>Shopify</s-heading></s-stack>
6-
<s-stack paddingInline="small-300" paddingBlockEnd="small-500" paddingBlockStart="small-400" gap="small-500">
7-
<s-clickable borderRadius="base"><s-stack direction="inline" paddingBlock="small-300"paddingInline="small-300"gap="small-300"><s-icon type="discount"></s-icon><s-text>Apply discount</s-text></s-stack></s-clickable>
8-
<s-clickable borderRadius="base"><s-stack direction="inline" paddingBlock="small-300"paddingInline="small-300"gap="small-300"><s-icon type="email"></s-icon><s-text>Email segment</s-text></s-stack></s-clickable>
9-
<s-clickable borderRadius="base"><s-stack direction="inline" paddingBlock="small-300"paddingInline="small-300"gap="small-300"><s-icon type="store-managed"></s-icon><s-text>Issue store credit</s-text></s-stack></s-clickable>
10-
<s-clickable borderRadius="base"><s-stack direction="inline" paddingBlock="small-300"paddingInline="small-300"gap="small-300"><s-icon type="automation"></s-icon><s-text>Start automation</s-text></s-stack></s-clickable>
11-
</s-stack>
12-
13-
<s-divider></s-divider>
14-
15-
<s-stack paddingBlockStart="none" gap="small-300">
16-
<s-stack paddingInline="small-100" paddingBlockStart="small"><s-heading>Apps</s-heading></s-stack>
17-
18-
<s-stack paddingInline="small-300" gap="small-300">
19-
<s-clickable paddingBlock="small-300" paddingInline="small-300" borderRadius="base">
20-
<s-stack direction="inline" alignItems="center" gap="small-300">
21-
<s-avatar size="small-200" src="https://cdn.shopify.com/app-store/listing_images/15100ebca4d221b650a7671125cd1444/icon/CO25r7-jh4ADEAE=.png"></s-avatar>
22-
<s-stack>
23-
<s-text>Shopify Flow</s-text>
24-
<s-text color="subdued">Create an automation</s-text>
25-
</s-stack>
26-
</s-stack>
27-
</s-clickable>
28-
<s-clickable paddingBlock="small-300" paddingInline="small-300" borderRadius="base">
29-
<s-stack direction="inline" alignItems="center" gap="small-300">
30-
<s-avatar size="small-200" src="https://cdn.shopify.com/app-store/listing_images/87176a11f3714753fdc2e1fc8bbf0415/icon/CIqiqqXsiIADEAE=.png"></s-avatar>
31-
<s-stack>
32-
<s-text>Shopify Planet</s-text>
33-
<s-text color="subdued">Add carbon-neutral shipping</s-text>
34-
</s-stack>
35-
</s-stack>
36-
</s-clickable>
37-
</s-stack>
38-
<s-stack paddingInline="small-100" paddingBlockEnd="small-100"><s-link href="">View all</s-link></s-stack>
39-
</s-stack>
40-
</s-stack>
41-
</s-popover>
1+
<s-stack alignItems="center">
2+
<s-text>Learn more about <s-link href="">creating puzzles</s-link>.</s-text>
3+
</s-stack>

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
<s-section accessibilityLabel="Empty state section">
2222
<s-grid gap="base" justifyItems="center" paddingBlock="large-400">
2323
<s-box maxInlineSize="200px" maxBlockSize="200px">
24+
<!-- aspectRatio should match the actual image dimensions (width/height) -->
2425
<s-image
2526
maxInlineSize="200px"
2627
maxBlockSize="200px"

0 commit comments

Comments
 (0)