feat:✨Added a support for showing message time in message bubble. Rem… #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsaltanna
reviewed
Sep 29, 2023
lib/src/values/enumaration.dart
Outdated
| bool get noMessages => this == ChatViewState.noData; | ||
| } | ||
|
|
||
| enum ShowMessageCreateTime { |
| ), | ||
| ), | ||
| const SizedBox(width: 4), | ||
| messageDateTimeBuilder?.call(messageTime) ?? |
Collaborator
There was a problem hiding this comment.
use this as parent widget.
| if (!showMessageTimeIn.isOnRightSwipe && | ||
| !showMessageTimeIn.isDisable) | ||
| Positioned( | ||
| right: message.reaction.reactions.isNotEmpty ? 16 : 18, |
Collaborator
There was a problem hiding this comment.
this static value might break something, please assure all the possible scenarios.
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final showMessageTimeIn = ChatViewInheritedWidget.of(context)! |
Collaborator
There was a problem hiding this comment.
should not use force unwrap here
lib/src/utils/package_strings.dart
Outdated
| static const String send = "Send"; | ||
| static const String you = "You"; | ||
| static const String emptyString = ''; | ||
| static const String messageTimeSpacing =' '; |
Collaborator
There was a problem hiding this comment.
should not use static spacing like this.
| color: Colors.white, | ||
| fontSize: 16, | ||
| ), | ||
| final showMessageTimeIn = ChatViewInheritedWidget.of(context)! |
jaiminrana05
force-pushed
the
fix/issue_115_show_message_time_in_bubble
branch
3 times, most recently
from
9f9abde to
aa97eba
Compare
|
@jaiminrana05 When we will get these changes in release |
apurva010
force-pushed
the
fix/issue_115_show_message_time_in_bubble
branch
from
aa97eba to
d096245
Compare
…oved enableSwipeToSeeTime(bool) & added messageTimePositionType(Enum) to FeatureActiveConfig class.(#115)
apurva010
force-pushed
the
fix/issue_115_show_message_time_in_bubble
branch
from
d096245 to
c3a917e
Compare
|
When can we get these changes in release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enableSwipeToSeeTime(bool) & added showMessageTimeIn(Enum) from FeatureActiveConfig class.(#115)
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #115