Entities subscription

[DiegoAlar]

Hi,

I'm having the following issue with the library in this part of the code:

apollo-federation-php/src/FederatedSchema.php

Lines 215 to 227 in 4f958dd

	*/
	private function extractEntityTypes(array $config): array
	{
	$resolvedTypes = TypeInfo::extractTypes($config['query']);
	$entityTypes = [];
	foreach ($resolvedTypes as $type) {
	if ($type instanceof EntityObjectType) {
	$entityTypes[$type->name] = $type;
	}
	}
	return $entityTypes;

The issue is that the library is unable to subscribe entities that aren't returned by a query.

Thank you!

[Aeliot-Tm]

@DiegoAlar Could you describe your problem more verbose?

P.s.
Provide link to exact version instead of main branch, please. Otherwise, it might be broken after the merging of any changes.

[magnusnordlander]

@Aeliot-Tm I think we're experiencing the same issue, in which case the issue is that if a type is not directly or indirectly referenced by the Query type, the type is not discovered as an entity.

Consider the following sub-graph schemas:

# Subgraph A

extend type Query {
	restaurants: [Restaurant!]!
}

type Restaurant {
	id: ID! @key
	name: String!
}


# Subgraph B

extend type Query {
	locations: [Location!]!
}

type Location {
	lat: Float!
	long: Float!
}

extend type Restaurant {
	id: ID! @key
	location: Location!
}

Note that in Subgraph B, the Query type does not reference the Restaurant Type. If this schema is implemented using this library, it is unable to discover that the Restaurant type is an Entity, because Apollo\Federation\FederatedSchema::extractEntityTypes gets its list of candidate types from $config['query'] (cf. https://github.com/Skillshare/apollo-federation-php/blob/4f958dd/src/FederatedSchema.php#L218 ).