Distinguish beween NGE and pre-CU

[Sobuno]

The current code primarily supports pre-CU with a few NGE features left intact in the code that I have not eliminated yet.

What is the best way to keep a version for NGE around? It would not need to be updated with new features, but having general bug fixes applied to both version would be nice.

[cbortz]

Hmmm this is a great question... I didn't play too much NGE, and certainly didn't do any crafting so I don't know how it differs from Pre-CU.

That being said, I am going to work with the assumption that there are minor changes (stat types, caps, etc). I think those could be implemented as some sort of template with project variables.

This way you can extract the basic UI elements (installation, setup, mail, resource, etc) into the platform that runs the Pre-CU and the NGE versions.

In each of the versions, you keep different settings and templates. An example would be

Once again, I am completely spitballing here 👍

[Sobuno]

The crafting system is mostly untouched with the NGE, it is primarly the profession system that was turned into a level-based system with these expertise trees that are akin to talent trees in WoW I think (I never played the NGE, but have been running SWGCraft since 2007 so you pick up a bit at a time).

I ripped out a lot of the expertise-related code the other day, but there may be remnants around. I think it would be hard to implement it as some sort of template system and I have no idea how hard it is to keep two "master" branches around.

[cbortz]

I think what you end up with potentially is a version-based source, where each version has a reference in git, allowing different projects to reference it... at the risk of being pedantic, I'm going to set the stage with an example:

• SWGAidePlatform will refer to the universal platform
• SWGAidePreCU will refer to Pre-CU specific implementation
• SWGAideNGE will refer to NGA specific implementation

SWGAidePlatform is at version 1.0.0 and you have a branch called 1.0.0. SWGAidePreCU and SWGAideNGE are both using 1.0.0.

Now, you're working on tweaks to SWGAidePlatform, and have a tag setup for let's say 1.0.1. Before you launch this, you would probably want to test the changes on the respective SWGAidePreCU and SWGAideNGE projects.

So, on SWGAidePreCU you create a branch (and tag?) for implementing version 1.0.1 of SWGAidePlatform. Everything checks out.

You then test out the changes on a new branch of SWGAideNGE and things are broken! Uh oh... the good news is, since you still have the 1.0.0 tag, you could potentially release the update to SWGAidePreCU and work on getting SWGAideNGE up to speed.

[twistedatrocity]

Hi,

I'm working on an NGE fork of this and the only problem so far I am running into is the files related to professions and schematics that swgcraft sends are by default Pre-CU. Is it possible they have a flag to spit out the nge versions, or if there is one implemented could you let me know what it is?

E.g. the following files makes it not behave well when trying to use in NGE mode.

• /dev/sendfile.php?file=categories.xml
• /dev/sendfile.php?file=myprofsecret.xml
• /dev/sendfile.php?file=schematics.xml.gz

maybe a &mode=nge or something? I have tried using the nge flag that the website uses with no luck, assuming it's just not implemented on the sendfile script.

Thanks

[Sobuno]

I have set up NGE versions to be generated now. The file names are the same except with _nge suffixed to the base filename, i.e. categories_nge.xml etc.

I have not verified how the output looks, but leave a comment here if something's wrong.

[twistedatrocity]

You are awesome, thanks! The outputs are just fine.