From ea108559e671add6b90d35b014e080a1dfc36399 Mon Sep 17 00:00:00 2001
From: midenotch <midenotch@users.noreply.github.com>
Date: Wed, 26 Aug 2026 11:46:20 +0100
Subject: [PATCH] chore: remove dead upgrade_test.rs module

The file was never registered in lib.rs, so it never compiled or ran.
It also called stale APIs:
- init with one arg instead of three
- create_escrow without metadata_hash
- non-existent try_upgrade method
- Vec<u8> instead of [u8; 32] for upgrade

Removing it eliminates dead code as requested.
---
 apps/onchain/src/upgrade_test.rs | 68 --------------------------------
 1 file changed, 68 deletions(-)
 delete mode 100644 apps/onchain/src/upgrade_test.rs

diff --git a/apps/onchain/src/upgrade_test.rs b/apps/onchain/src/upgrade_test.rs
deleted file mode 100644
index e1239d6f..00000000
--- a/apps/onchain/src/upgrade_test.rs
+++ /dev/null
@@ -1,68 +0,0 @@
-use super::*;
-use soroban_sdk::{testutils::Address as _, testutils::Events, Env, Address, Vec, Symbol};
-
-#[test]
-fn test_admin_upgrade_and_state_preservation() {
-    let env = Env::default();
-    env.mock_all_auths();
-
-    // Deploy version A
-    let contract_id = env.register_contract(None, VaultixEscrow);
-    let client = VaultixEscrowClient::new(&env, &contract_id);
-
-    // Set admin
-    let admin = Address::generate(&env);
-    client.init(&admin);
-
-    // Create escrow
-    let depositor = Address::generate(&env);
-    let recipient = Address::generate(&env);
-    let token_address = Address::generate(&env);
-    let milestones = Vec::new(&env);
-    milestones.push_back(Milestone {
-        amount: 1000,
-        status: MilestoneStatus::Pending,
-        description: Symbol::new(&env, "Test"),
-    });
-    let deadline = 1706400000u64;
-    client.create_escrow(&1u64, &depositor, &recipient, &token_address, &milestones, &deadline);
-
-    // Simulate upgrade: deploy version B (same contract, but would add a helper in real scenario)
-    let new_wasm_hash = vec![&env, 1u8, 2u8, 3u8]; // Dummy hash for test
-    let result = client.try_upgrade(&new_wasm_hash);
-    assert!(result.is_ok());
-
-    // State should be preserved
-    let escrow = client.get_escrow(&1u64);
-    assert_eq!(escrow.depositor, depositor);
-    assert_eq!(escrow.recipient, recipient);
-    assert_eq!(escrow.total_amount, 1000);
-
-    // Event should be emitted
-    let events = env.events().all();
-    let found = events.iter().any(|e| {
-        let topics: Vec<_> = e.1.into_val(&env);
-        topics.contains(&Symbol::new(&env, "ContractUpgraded").into_val(&env))
-    });
-    assert!(found);
-}
-
-#[test]
-fn test_upgrade_rejects_non_admin() {
-    let env = Env::default();
-    env.mock_all_auths();
-
-    let contract_id = env.register_contract(None, VaultixEscrow);
-    let client = VaultixEscrowClient::new(&env, &contract_id);
-
-    // Set admin
-    let admin = Address::generate(&env);
-    client.init(&admin);
-
-    // Try upgrade as non-admin
-    let new_wasm_hash = vec![&env, 1u8, 2u8, 3u8];
-    let not_admin = Address::generate(&env);
-    env.set_source_account(&not_admin);
-    let result = client.try_upgrade(&new_wasm_hash);
-    assert_eq!(result, Err(Ok(Error::UnauthorizedAccess)));
-}