Skip to content

Commit 094d99d

Browse files
authored
fixup I_A calc
1 parent 3812d54 commit 094d99d

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/imply/RAM/generic.jl

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,8 @@ function objective!(imply::RAM, parameters, model, has_meanstructure::Val{T}) wh
224224
parameters,
225225
)
226226

227-
@inbounds for (j, I_Aj, Aj) in
228-
zip(axes(imply.A, 2), eachcol(imply.I_A), eachcol(imply.A))
229-
for i in axes(imply.A, 1)
230-
I_Aj[i] = ifelse(i == j, 1, 0) - Aj[i]
231-
end
232-
end
227+
@. I_A = -A
228+
@view(I_A[diagind(I_A)]) .+= 1
233229

234230
copyto!(imply.F⨉I_A⁻¹, imply.F)
235231
rdiv!(imply.F⨉I_A⁻¹, factorize(imply.I_A))
@@ -257,12 +253,8 @@ function gradient!(
257253
parameters,
258254
)
259255

260-
@inbounds for (j, I_Aj, Aj) in
261-
zip(axes(imply.A, 2), eachcol(imply.I_A), eachcol(imply.A))
262-
for i in axes(imply.A, 1)
263-
I_Aj[i] = ifelse(i == j, 1, 0) - Aj[i]
264-
end
265-
end
256+
@. I_A = -A
257+
@view(I_A[diagind(I_A)]) .+= 1
266258

267259
imply.I_A⁻¹ = LinearAlgebra.inv!(factorize(imply.I_A))
268260
mul!(imply.F⨉I_A⁻¹, imply.F, imply.I_A⁻¹)

0 commit comments

Comments
 (0)