Skip to content

Commit e3a5d2f

Browse files
Alexey Stukalovalyst
authored andcommitted
EM MVN: report rel_error if not converged
1 parent 8afedcb commit e3a5d2f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/observed/EM.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ function em_mvn(
5555

5656
iter = 0
5757
converged = false
58+
Δμ_rel = NaN
59+
ΔΣ_rel = NaN
5860
while !converged && (iter < max_iter_em)
5961
em_step!(Σ, μ, Σ_prev, μ_prev, patterns, 𝔼x_full, 𝔼xxᵀ_full)
6062

@@ -76,7 +78,7 @@ function em_mvn(
7678
end
7779

7880
if !converged
79-
@warn "EM Algorithm for MVN missing data did not converge in $iter iterations.\n" *
81+
@warn "EM Algorithm for MVN missing data did not converge in $iter iterations (ΔΣ/Σ=$(ΔΣ_rel) Δμ/μ=$(Δμ_rel)).\n" *
8082
"Likelihood for FIML is not interpretable.\n" *
8183
"Maybe try passing different starting values via 'start_em = ...' "
8284
else

0 commit comments

Comments
 (0)