[FEATURE] Make templates overridable #1085
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the docker container locally or in a custom pipeline.
jaapio
requested changes
Oct 17, 2025
| ENV TYPO3AZUREEDGEURIVERSION=$TYPO3AZUREEDGEURIVERSION | ||
|
|
||
| WORKDIR /project | ||
| RUN mkdir -p /project/custom-templates |
Contributor
There was a problem hiding this comment.
Suggested change
| RUN mkdir -p /project/custom-templates | |
| RUN mkdir -p /templates |
| docker run --rm \ | ||
| --pull always \ | ||
| -v "$(pwd):/project" \ | ||
| -v "$(pwd)/my-custom-templates:/project/custom-templates:ro" \ |
Contributor
There was a problem hiding this comment.
I would recommend to use a separate root path for the templates. Like /templates this prevents strange behavior in the order of volumes. In the order you wrote it it will work. Otherway around it does not. People might be unaware of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the docker container locally
or in a custom pipeline.