[TASK] Update to phpstan v2

bmack · bmack · commit af142740fd0b · 2024-11-12T09:34:00.000+01:00
diff --git a/composer.json b/composer.json
@@ -42,11 +42,11 @@
 		"maglnet/composer-require-checker": "^4.7.1",
 		"overtrue/phplint": "^9.0",
 		"phpstan/extension-installer": "^1.3.1",
-		"phpstan/phpstan": "^1.11.3",
-		"phpstan/phpstan-deprecation-rules": "^1.2.0",
-		"phpstan/phpstan-phpunit": "^1.4.0",
-		"phpstan/phpstan-strict-rules": "^1.6.0",
-		"phpstan/phpstan-symfony": "^1.4.3",
+		"phpstan/phpstan": "^2.0",
+		"phpstan/phpstan-deprecation-rules": "^2.0",
+		"phpstan/phpstan-phpunit": "^2.0",
+		"phpstan/phpstan-strict-rules": "^2.0",
+		"phpstan/phpstan-symfony": "^2.0",
 		"phpunit/phpunit": "^10.1.3",
 		"symfony/finder": "^6.4 || ^7.0",
 		"symfony/process": "^6.4 || ^7.0"
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,5 @@
 parameters:
-	level: max
+	level: 9
 	phpVersion: 80100
 	treatPhpDocTypesAsCertain: true
 
@@ -11,6 +11,3 @@ parameters:
 	excludePaths:
 		analyse:
 			- tests/Console/Style/SimpleStyle.php
-
-	stubFiles:
-		- stubs/Command.stub
diff --git a/src/Console/Command/SetupCommand.php b/src/Console/Command/SetupCommand.php
@@ -92,7 +92,7 @@ private function getType(InputInterface $input): string
                 throw new RuntimeException(sprintf($composerManifestError, 'read')); // @codeCoverageIgnore
             }
 
-            $composerManifest = \json_decode($composerManifest, true, 512, 0);
+            $composerManifest = \json_decode($composerManifest, true);
             if ($composerManifest === false || !is_array($composerManifest)) {
                 throw new RuntimeException(sprintf($composerManifestError, 'decoded'));
             }
diff --git a/stubs/Command.stub b/stubs/Command.stub
diff --git a/tests/Unit/CsFixerConfigTest.php b/tests/Unit/CsFixerConfigTest.php
@@ -23,9 +23,7 @@ final class CsFixerConfigTest extends TestCase
 {
     public function testCreateReturnsCorrectClass(): void
     {
-        /** @var object $csFixerConfig */
         $csFixerConfig = CsFixerConfig::create();
-        self::assertInstanceOf(CsFixerConfig::class, $csFixerConfig);
         self::assertTrue($csFixerConfig->getRiskyAllowed());
         self::assertCount(52, $csFixerConfig->getRules());
     }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ private function getType(InputInterface $input): string`
`92`	`92`	`throw new RuntimeException(sprintf($composerManifestError, 'read')); // @codeCoverageIgnore`
`93`	`93`	`}`
`94`	`94`
`95`		`- $composerManifest = \json_decode($composerManifest, true, 512, 0);`
	`95`	`+ $composerManifest = \json_decode($composerManifest, true);`
`96`	`96`	`if ($composerManifest === false \|\| !is_array($composerManifest)) {`
`97`	`97`	`throw new RuntimeException(sprintf($composerManifestError, 'decoded'));`
`98`	`98`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,7 @@ final class CsFixerConfigTest extends TestCase`
`23`	`23`	`{`
`24`	`24`	`public function testCreateReturnsCorrectClass(): void`
`25`	`25`	`{`
`26`		`- /** @var object $csFixerConfig */`
`27`	`26`	`$csFixerConfig = CsFixerConfig::create();`
`28`		`- self::assertInstanceOf(CsFixerConfig::class, $csFixerConfig);`
`29`	`27`	`self::assertTrue($csFixerConfig->getRiskyAllowed());`
`30`	`28`	`self::assertCount(52, $csFixerConfig->getRules());`
`31`	`29`	`}`