refactor(datagrid): align selection visuals with native macOS patterns

Selection rendering was inverted: a 1.5pt 100% accent border was the dominant feature while the header and body fills were a barely visible 18% accent. The pattern in NSTableView row selection, Numbers, and Excel is the opposite, fill carries the meaning and borders are subtle or absent.

Header now fills with NSColor.selectedContentBackgroundColor at full opacity when its column is selected, with text and sort indicator switched to alternateSelectedControlTextColor for contrast. This makes the header the strong anchor of a column selection, the way Numbers does it.

Body fill bumped from 0.18 to 0.28 alpha so the selection reads as deliberate without competing with the row striping.

Perimeter border now skips full-height rectangles (column selections, full-grid selectAll) because the header and fill already communicate the selection there. For arbitrary rectangles produced by drag and shift+drag, the border is now 1pt at 70% of the fill hue instead of 1.5pt at 100% accent, so it relates visually to the fill instead of overpowering it.

Active-cell border is unchanged at 2pt controlAccentColor, only drawn when the selection spans more than one cell.

Author: datlechin

TablePro/Views/Results/DataGridRowView.swift

@@ -101,7 +101,7 @@ class DataGridRowView: NSTableRowView {
 
         let fillColor: NSColor = isSelected
             ? NSColor.unemphasizedSelectedContentBackgroundColor
-            : NSColor.selectedContentBackgroundColor.withAlphaComponent(0.18)
+            : NSColor.selectedContentBackgroundColor.withAlphaComponent(0.28)
         fillColor.setFill()
 
         let schema = coordinator?.identitySchema

TablePro/Views/Results/Selection/GridSelectionOverlay.swift

@@ -12,8 +12,9 @@ final class GridSelectionOverlay: NSView {
     weak var tableView: NSTableView?
     weak var coordinator: TableViewCoordinator?
 
-    private static let borderWidth: CGFloat = 1.5
+    private static let borderWidth: CGFloat = 1.0
     private static let activeCellBorderWidth: CGFloat = 2.0
+    private static let borderAlpha: CGFloat = 0.7
 
     override init(frame frameRect: NSRect) {
         super.init(frame: frameRect)
@@ -34,11 +35,13 @@ final class GridSelectionOverlay: NSView {
     override func draw(_ dirtyRect: NSRect) {
         guard let tableView, let coordinator else { return }
         let schema = coordinator.identitySchema
+        let totalRows = tableView.numberOfRows
 
-        NSColor.selectedContentBackgroundColor.setStroke()
+        NSColor.selectedContentBackgroundColor.withAlphaComponent(Self.borderAlpha).setStroke()
         for rect in selection.rectangles {
             guard let frame = frame(for: rect, in: tableView, schema: schema) else { continue }
             guard frame.intersects(dirtyRect) else { continue }
+            if isFullHeight(rect, totalRows: totalRows) { continue }
             let inset = frame.insetBy(dx: Self.borderWidth / 2, dy: Self.borderWidth / 2)
             let path = NSBezierPath(rect: inset)
             path.lineWidth = Self.borderWidth
@@ -57,6 +60,11 @@ final class GridSelectionOverlay: NSView {
         }
     }
 
+    private func isFullHeight(_ rect: GridRect, totalRows: Int) -> Bool {
+        guard totalRows > 0 else { return false }
+        return rect.rows.lowerBound <= 0 && rect.rows.upperBound >= totalRows - 1
+    }
+
     private func frame(for rect: GridRect, in tableView: NSTableView, schema: ColumnIdentitySchema) -> NSRect? {
         guard tableView.numberOfRows > 0, tableView.numberOfColumns > 0 else { return nil }
         let firstRow = max(0, rect.rows.lowerBound)

TablePro/Views/Results/SortableHeaderCell.swift

@@ -32,15 +32,20 @@ final class SortableHeaderCell: NSTableHeaderCell {
 
     override func drawInterior(withFrame cellFrame: NSRect, in controlView: NSView) {
         if isColumnSelected {
-            NSColor.controlAccentColor.withAlphaComponent(0.18).setFill()
+            NSColor.selectedContentBackgroundColor.setFill()
             cellFrame.fill()
         }
 
-        drawTitle(in: titleRect(forBounds: cellFrame), font: titleFont(isSorted: sortDirection != nil))
+        let foreground = foregroundColor(emphasized: isColumnSelected)
+        drawTitle(
+            in: titleRect(forBounds: cellFrame),
+            font: titleFont(isSorted: sortDirection != nil),
+            color: foreground
+        )
 
         guard let direction = sortDirection else { return }
 
-        let indicatorImage = Self.indicatorImage(for: direction)
+        let indicatorImage = Self.indicatorImage(for: direction, color: foreground)
         let indicatorSize = indicatorImage?.size ?? Self.defaultIndicatorSize
         let indicatorOriginX = cellFrame.maxX - Self.indicatorPadding - indicatorSize.width
         let indicatorOriginY = cellFrame.midY - indicatorSize.height / 2
@@ -53,15 +58,15 @@ final class SortableHeaderCell: NSTableHeaderCell {
         Self.drawIndicator(image: indicatorImage, in: indicatorRect)
 
         if let priorityText = priorityNumberString() {
-            let priorityWidth = Self.measureWidth(of: priorityText)
+            let priorityWidth = Self.measureWidth(of: priorityText, color: foreground)
             let textOriginX = indicatorOriginX - Self.indicatorSpacing - priorityWidth
             let textRect = NSRect(
                 x: textOriginX,
                 y: cellFrame.minY,
                 width: priorityWidth,
                 height: cellFrame.height
             )
-            Self.drawPriorityText(priorityText, in: textRect)
+            Self.drawPriorityText(priorityText, in: textRect, color: foreground)
         }
     }
 
@@ -78,10 +83,10 @@ final class SortableHeaderCell: NSTableHeaderCell {
 
     private func reservedTrailingWidth() -> CGFloat {
         guard let direction = sortDirection else { return 0 }
-        let indicatorWidth = Self.indicatorImage(for: direction)?.size.width
+        let indicatorWidth = Self.indicatorImage(for: direction, color: .secondaryLabelColor)?.size.width
             ?? Self.defaultIndicatorSize.width
         let priorityText = priorityNumberString()
-        let priorityComponent = priorityText.map { Self.measureWidth(of: $0) + Self.indicatorSpacing } ?? 0
+        let priorityComponent = priorityText.map { Self.measureWidth(of: $0, color: .secondaryLabelColor) + Self.indicatorSpacing } ?? 0
         return indicatorWidth + Self.indicatorPadding * 2 + priorityComponent
     }
 
@@ -91,14 +96,18 @@ final class SortableHeaderCell: NSTableHeaderCell {
         return NSFontManager.shared.convert(baseFont, toHaveTrait: .boldFontMask)
     }
 
-    private func drawTitle(in rect: NSRect, font titleFont: NSFont) {
+    private func foregroundColor(emphasized: Bool) -> NSColor {
+        emphasized ? .alternateSelectedControlTextColor : .headerTextColor
+    }
+
+    private func drawTitle(in rect: NSRect, font titleFont: NSFont, color: NSColor) {
         let paragraph = NSMutableParagraphStyle()
         paragraph.alignment = alignment
         paragraph.lineBreakMode = .byTruncatingTail
 
         let attributes: [NSAttributedString.Key: Any] = [
             .font: titleFont,
-            .foregroundColor: NSColor.headerTextColor,
+            .foregroundColor: color,
             .paragraphStyle: paragraph
         ]
 
@@ -142,10 +151,10 @@ final class SortableHeaderCell: NSTableHeaderCell {
         return String(sortPriority)
     }
 
-    private static func indicatorImage(for direction: SortDirection) -> NSImage? {
+    private static func indicatorImage(for direction: SortDirection, color: NSColor) -> NSImage? {
         let symbolName = direction == .ascending ? "chevron.up" : "chevron.down"
         let configuration = NSImage.SymbolConfiguration(pointSize: priorityFontSize, weight: .semibold)
-            .applying(.init(hierarchicalColor: .secondaryLabelColor))
+            .applying(.init(hierarchicalColor: color))
         return NSImage(systemSymbolName: symbolName, accessibilityDescription: nil)?
             .withSymbolConfiguration(configuration)
     }
@@ -162,8 +171,8 @@ final class SortableHeaderCell: NSTableHeaderCell {
         )
     }
 
-    private static func drawPriorityText(_ text: String, in rect: NSRect) {
-        let attributes = priorityAttributes()
+    private static func drawPriorityText(_ text: String, in rect: NSRect, color: NSColor) {
+        let attributes = priorityAttributes(color: color)
         let textSize = (text as NSString).size(withAttributes: attributes)
         let drawRect = NSRect(
             x: rect.minX,
@@ -174,14 +183,14 @@ final class SortableHeaderCell: NSTableHeaderCell {
         (text as NSString).draw(in: drawRect, withAttributes: attributes)
     }
 
-    private static func measureWidth(of text: String) -> CGFloat {
-        (text as NSString).size(withAttributes: priorityAttributes()).width
+    private static func measureWidth(of text: String, color: NSColor) -> CGFloat {
+        (text as NSString).size(withAttributes: priorityAttributes(color: color)).width
     }
 
-    private static func priorityAttributes() -> [NSAttributedString.Key: Any] {
+    private static func priorityAttributes(color: NSColor) -> [NSAttributedString.Key: Any] {
         [
             .font: NSFont.systemFont(ofSize: priorityFontSize, weight: .medium),
-            .foregroundColor: NSColor.secondaryLabelColor
+            .foregroundColor: color
         ]
     }
 }