Skip to content

Commit c7710c6

Browse files
committed
fix(security): allow plain HTTP to DNS hosts for database connections (#1316)
1 parent d7fa797 commit c7710c6

4 files changed

Lines changed: 20 additions & 11 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3333

3434
### Fixed
3535

36+
- ClickHouse (and any HTTP-based driver) can now connect to plain-HTTP servers addressed by DNS hostname; previously App Transport Security blocked the request because only IP-addressed plain HTTP is exempt by default (#1316)
3637
- Import from TablePlus now reads passwords from the keychain correctly; previously it queried the wrong service name and silently returned empty passwords without prompting
3738
- Port numbers in the import preview, welcome screen linked-file list, and plugin details no longer render with a thousand separator (e.g. 3306 instead of 3.306) under Vietnamese, German, and other locales that use a dot as a digit separator
3839
- New query tab (Cmd+T) no longer jumps focus back to the previous table tab on SQLite and other file-based databases (#1313)

TablePro/Info.plist

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,11 @@
237237
</dict>
238238
</dict>
239239
</array>
240+
<key>NSAppTransportSecurity</key>
241+
<dict>
242+
<key>NSAllowsArbitraryLoads</key>
243+
<true/>
244+
</dict>
240245
<key>NSUserActivityTypes</key>
241246
<array>
242247
<string>com.TablePro.viewConnection</string>

TablePro/Resources/Localizable.xcstrings

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1362,6 +1362,7 @@
13621362
}
13631363
},
13641364
"%@: %lld" : {
1365+
"extractionState" : "stale",
13651366
"localizations" : {
13661367
"en" : {
13671368
"stringUnit" : {
@@ -1418,17 +1419,6 @@
14181419
}
14191420
}
14201421
},
1421-
"%@:%lld" : {
1422-
"localizations" : {
1423-
"en" : {
1424-
"stringUnit" : {
1425-
"state" : "new",
1426-
"value" : "%1$@:%2$lld"
1427-
}
1428-
}
1429-
},
1430-
"shouldTranslate" : false
1431-
},
14321422
"%@." : {
14331423
"extractionState" : "stale",
14341424
"localizations" : {
@@ -2024,6 +2014,7 @@
20242014
}
20252015
},
20262016
"%lld pt" : {
2017+
"extractionState" : "stale",
20272018
"localizations" : {
20282019
"tr" : {
20292020
"stringUnit" : {
@@ -23410,6 +23401,7 @@
2341023401
}
2341123402
},
2341223403
"hostname:%lld" : {
23404+
"extractionState" : "stale",
2341323405
"localizations" : {
2341423406
"tr" : {
2341523407
"stringUnit" : {
@@ -35123,6 +35115,9 @@
3512335115
}
3512435116
}
3512535117
}
35118+
},
35119+
"Preferred connects in plain TCP for this driver. Use Required to enforce TCPS." : {
35120+
3512635121
},
3512735122
"Preferred performs a 2-pass connect: tries TLS first, falls back to plain only on SSL handshake errors. Required by Cloud SQL and Azure MySQL." : {
3512835123

@@ -47404,6 +47399,9 @@
4740447399
},
4740547400
"This driver does not expose routine DDL." : {
4740647401

47402+
},
47403+
"This driver has no TLS fallback. Preferred forces TLS, same as Required." : {
47404+
4740747405
},
4740847406
"This DROP query will permanently remove database objects. This action cannot be undone." : {
4740947407
"localizations" : {

TableProMobile/TableProMobile/Info.plist

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@
66
<string>$(ANALYTICS_HMAC_SECRET)</string>
77
<key>AppIdentifierPrefix</key>
88
<string>$(AppIdentifierPrefix)</string>
9+
<key>NSAppTransportSecurity</key>
10+
<dict>
11+
<key>NSAllowsArbitraryLoads</key>
12+
<true/>
13+
</dict>
914
<key>NSFaceIDUsageDescription</key>
1015
<string>TablePro uses Face ID to protect your saved database connections and credentials.</string>
1116
<key>NSLocalNetworkUsageDescription</key>

0 commit comments

Comments
 (0)