Merge remote-tracking branch 'origin/main' into fix/external-access-persistence

# Conflicts:
#	CHANGELOG.md
#	TablePro/Core/Storage/StoredConnection.swift

Author: datlechin

CHANGELOG.md

@@ -7,11 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Data grid now serves the row count from its existing cache instead of recomputing it on every layout pass, reducing CPU churn while scrolling large result sets.
+- Typing in the sidebar table search stays responsive on databases with thousands of tables; filtering runs after a short pause instead of on every keystroke.
+
 ### Fixed
 
 - Oracle connections no longer crash the app when the server sends a backend message the driver cannot decode; the query fails with a clear error and the connection reconnects. (#483)
 - MongoDB TLS handshake failures now report the actual cause instead of always blaming a cipher or protocol mismatch. (#1418)
 - The External Clients access level no longer reverts to Read Only after saving and reopening a connection, so MCP clients keep the write access you granted. (#1730)
+- Typing fast with the autocomplete window open no longer stalls each keystroke; the live refilter is debounced, cancelable, and moved off the main thread.
 
 ## [0.52.0] - 2026-06-19
 

Plugins/BigQueryDriverPlugin/BigQueryAuth.swift

@@ -88,7 +88,7 @@ internal final class ServiceAccountAuthProvider: @unchecked Sendable, BigQueryAu
 
         self.clientEmail = email
         self.privateKeyPEM = key
-        self.projectId = overrideProjectId?.isEmpty == false ? overrideProjectId! : saProjectId
+        self.projectId = overrideProjectId.flatMap { $0.isEmpty ? nil : $0 } ?? saProjectId
 
         if self.projectId.isEmpty {
             throw BigQueryError.authFailed("No project ID found in service account JSON or connection settings")
@@ -349,9 +349,7 @@ internal final class ADCAuthProvider: @unchecked Sendable, BigQueryAuthProvider
             }
 
             let quotaProject = json["quota_project_id"] as? String ?? ""
-            self.projectId = overrideProjectId?.isEmpty == false
-                ? overrideProjectId!
-                : quotaProject
+            self.projectId = overrideProjectId.flatMap { $0.isEmpty ? nil : $0 } ?? quotaProject
 
             if self.projectId.isEmpty {
                 throw BigQueryError.authFailed(
@@ -374,9 +372,7 @@ internal final class ADCAuthProvider: @unchecked Sendable, BigQueryAuthProvider
             }
 
             // Resolve source credentials
-            let resolvedProjectId = overrideProjectId?.isEmpty == false
-                ? overrideProjectId!
-                : (json["quota_project_id"] as? String ?? "")
+            let resolvedProjectId = overrideProjectId.flatMap { $0.isEmpty ? nil : $0 } ?? (json["quota_project_id"] as? String ?? "")
 
             if resolvedProjectId.isEmpty {
                 throw BigQueryError.authFailed(
@@ -548,7 +544,6 @@ private final class ImpersonatedServiceAccountDelegate: @unchecked Sendable, Big
     }
 
     private func fetchImpersonatedToken() async throws -> String {
-        // Get source token
         let sourceToken = try await sourceProvider.accessToken()
 
         // Exchange for impersonated token
@@ -649,7 +644,6 @@ internal final class OAuthBrowserAuthProvider: @unchecked Sendable, BigQueryAuth
 
         let redirectUri = "http://127.0.0.1:\(port)"
 
-        // Build authorization URL
         var components = URLComponents(string: Self.authEndpoint)
         components?.queryItems = [
             URLQueryItem(name: "client_id", value: clientId),
@@ -665,7 +659,6 @@ internal final class OAuthBrowserAuthProvider: @unchecked Sendable, BigQueryAuth
             throw BigQueryError.authFailed("Failed to build OAuth authorization URL")
         }
 
-        // Open browser
         Self.logger.info("Opening browser for OAuth authorization")
         await NSWorkspace.shared.open(authUrl)
 
@@ -680,13 +673,10 @@ internal final class OAuthBrowserAuthProvider: @unchecked Sendable, BigQueryAuth
 
         Self.logger.info("Received OAuth authorization code")
 
-        // Exchange auth code for tokens
         let tokens = try await exchangeAuthCode(code, redirectUri: redirectUri)
 
-        // Store refresh token
         lock.withLock { _refreshToken = tokens.refreshToken }
 
-        // Cache access token
         let newToken = CachedToken(
             token: tokens.accessToken,
             expiresAt: Date().addingTimeInterval(Double(tokens.expiresIn))

Plugins/BigQueryDriverPlugin/BigQueryConnection.swift

@@ -317,7 +317,6 @@ internal final class BigQueryConnection: @unchecked Sendable {
             _session = urlSession
         }
 
-        // Test connectivity
         do {
             _ = try await executeQuery("SELECT 1")
         } catch {
@@ -428,7 +427,6 @@ internal final class BigQueryConnection: @unchecked Sendable {
             _currentJobLocation = jobRef.location
         }
 
-        // Poll for completion if not done
         let finalJobResponse: BQJobResponse
         if let state = jobResponse.status?.state, state != "DONE" {
             finalJobResponse = try await pollJobCompletion(
@@ -441,7 +439,6 @@ internal final class BigQueryConnection: @unchecked Sendable {
             finalJobResponse = jobResponse
         }
 
-        // Extract DML affected rows from job statistics
         let dmlAffectedRows: Int
         if let numStr = finalJobResponse.statistics?.query?.numDmlAffectedRows {
             dmlAffectedRows = Int(numStr) ?? 0
@@ -453,7 +450,6 @@ internal final class BigQueryConnection: @unchecked Sendable {
         let totalBytesBilled = finalJobResponse.statistics?.query?.totalBytesBilled
         let cacheHit = finalJobResponse.statistics?.query?.cacheHit
 
-        // Fetch first page of results
         let firstPage = try await getQueryResults(
             jobId: jobId, location: jobRef.location, auth: auth, session: session
         )

Plugins/BigQueryDriverPlugin/BigQueryOAuthServer.swift

@@ -35,7 +35,6 @@ internal final class BigQueryOAuthServer: @unchecked Sendable {
     func waitForAuthCode() async throws -> String {
         try await withCheckedThrowingContinuation { cont in
             lock.withLock { continuation = cont }
-            // Start 2-minute timeout
             let task = Task {
                 try? await Task.sleep(nanoseconds: 120_000_000_000)
                 self.lock.withLock {

Plugins/BigQueryDriverPlugin/BigQueryPluginDriver.swift

@@ -208,12 +208,10 @@ internal final class BigQueryPluginDriver: PluginDatabaseDriver, @unchecked Send
             )
         }
 
-        // Tagged browsing queries
         if BigQueryQueryBuilder.isTaggedQuery(trimmed) {
             return try await executeTaggedQuery(trimmed, conn: conn, startTime: startTime)
         }
 
-        // Regular GoogleSQL
         let dataset = lock.withLock { _currentDataset }
         let result: BQExecuteResult
         do {
@@ -871,7 +869,6 @@ internal final class BigQueryPluginDriver: PluginDatabaseDriver, @unchecked Send
         let typeNames = BigQueryTypeMapper.columnTypeNames(from: schema)
         let rows = BigQueryTypeMapper.flattenRows(from: result.queryResponse, schema: schema)
 
-        // Update column cache
         lock.withLock { _columnCache["\(params.dataset).\(params.table)"] = colNames }
 
         return PluginQueryResult(

Plugins/BigQueryDriverPlugin/BigQueryQueryBuilder.swift

@@ -173,7 +173,6 @@ internal struct BigQueryQueryBuilder {
         var sql = "SELECT * FROM \(fqTable)"
         var whereClauses: [String] = []
 
-        // Filters
         if let filters = params.filters, !filters.isEmpty {
             let rawMode = params.logicMode ?? "AND"
             let logicMode = (rawMode.uppercased() == "OR") ? "OR" : "AND"
@@ -183,11 +182,8 @@ internal struct BigQueryQueryBuilder {
             }
         }
 
-        // Search
         if let searchText = params.searchText, !searchText.isEmpty {
-            let searchCols = params.searchColumns?.isEmpty == false
-                ? params.searchColumns!
-                : columns
+            let searchCols = params.searchColumns.flatMap { $0.isEmpty ? nil : $0 } ?? columns
             let escapedSearch = searchText.replacingOccurrences(of: "'", with: "''")
             let searchClauses = searchCols.map { col in
                 "CAST(\(quoteIdentifier(col)) AS STRING) LIKE '%\(escapedSearch)%'"
@@ -201,7 +197,6 @@ internal struct BigQueryQueryBuilder {
             sql += " WHERE " + whereClauses.joined(separator: " AND ")
         }
 
-        // Sort
         if let sortColumns = params.sortColumns, !sortColumns.isEmpty {
             let orderClauses = sortColumns.compactMap { sort -> String? in
                 guard sort.columnIndex < columns.count else { return nil }
@@ -236,9 +231,7 @@ internal struct BigQueryQueryBuilder {
         }
 
         if let searchText = params.searchText, !searchText.isEmpty {
-            let searchCols = params.searchColumns?.isEmpty == false
-                ? params.searchColumns!
-                : columns
+            let searchCols = params.searchColumns.flatMap { $0.isEmpty ? nil : $0 } ?? columns
             let escapedSearch = searchText.replacingOccurrences(of: "'", with: "''")
             let searchClauses = searchCols.map { col in
                 "CAST(\(quoteIdentifier(col)) AS STRING) LIKE '%\(escapedSearch)%'"

Plugins/CassandraDriverPlugin/CassandraConnection.swift

@@ -288,7 +288,6 @@ actor CassandraConnectionActor {
 
         let startTime = Date()
 
-        // Prepare
         let prepareFuture = cass_session_prepare(session, cql)
         guard let prepareFuture else {
             throw CassandraPluginError.queryFailed("Failed to prepare statement")
@@ -307,7 +306,6 @@ actor CassandraConnectionActor {
         }
         defer { cass_prepared_free(prepared) }
 
-        // Bind parameters
         let statement = cass_prepared_bind(prepared)
         guard let statement else {
             throw CassandraPluginError.queryFailed("Failed to bind prepared statement")
@@ -331,7 +329,6 @@ actor CassandraConnectionActor {
             }
         }
 
-        // Execute
         let future = cass_session_execute(session, statement)
         guard let future else {
             throw CassandraPluginError.queryFailed("Failed to execute prepared statement")

Plugins/CassandraDriverPlugin/CassandraPlugin.swift

@@ -304,7 +304,6 @@ internal final class CassandraPluginDriver: PluginDatabaseDriver, @unchecked Sen
         """
         let result = try await execute(query: query)
 
-        // Parse and sort by kind order then position before mapping to PluginColumnInfo
         struct RawColumn {
             let name: String
             let dataType: String
@@ -390,7 +389,6 @@ internal final class CassandraPluginDriver: PluginDatabaseDriver, @unchecked Sen
                 let kind = row[safe: 1]?.asText ?? "COMPOSITES"
                 let options = row[safe: 2]?.asText ?? ""
 
-                // Extract target column from options map
                 var targetColumns: [String] = []
                 if let targetRange = options.range(of: "target: ") {
                     let target = String(options[targetRange.upperBound...])
@@ -419,7 +417,6 @@ internal final class CassandraPluginDriver: PluginDatabaseDriver, @unchecked Sen
     func fetchTableDDL(table: String, schema: String?) async throws -> String {
         let ks = resolveKeyspace(schema)
 
-        // Build DDL from schema metadata
         let columns = try await fetchColumns(table: table, schema: ks)
 
         let partitionKeys = columns.filter(\.isPrimaryKey)

Plugins/CloudflareD1DriverPlugin/CloudflareD1PluginDriver.swift

@@ -80,7 +80,7 @@ final class CloudflareD1PluginDriver: PluginDatabaseDriver, @unchecked Sendable
 
             guard let match = databases.first(where: { $0.name == databaseName }) else {
                 throw CloudflareD1Error(
-                    message: String(localized: "Database '\(databaseName)' not found in account")
+                    message: String(format: String(localized: "Database '%@' not found in account"), databaseName)
                 )
             }
             databaseId = match.uuid
@@ -603,7 +603,7 @@ final class CloudflareD1PluginDriver: PluginDatabaseDriver, @unchecked Sendable
 
         guard let resolvedUuid = uuid else {
             throw CloudflareD1Error(
-                message: String(localized: "Database '\(database)' not found")
+                message: String(format: String(localized: "Database '%@' not found"), database)
             )
         }
 

Plugins/CloudflareD1DriverPlugin/D1HttpClient.swift

@@ -377,7 +377,7 @@ final class D1HttpClient: @unchecked Sendable {
             Self.logger.warning("D1 rate limited. Retry-After: \(retryAfter ?? "not specified")")
             if let seconds = retryAfter {
                 throw D1HttpError(
-                    message: String(localized: "Rate limited by Cloudflare. Retry after \(seconds) seconds.")
+                    message: String(format: String(localized: "Rate limited by Cloudflare. Retry after %@ seconds."), seconds)
                 )
             } else {
                 throw D1HttpError(