Repository navigation
Fix parent directory entry visibility in empty folders - #4777
Merged
EmmanuelMess merged 1 commit intoNov 12, 2026
Merged
EmmanuelMess merged 1 commit into
EmmanuelMess merged 1 commit into
Conversation
EmmanuelMess
approved these changes
Nov 12, 2026
EmmanuelMess
left a comment
Member
There was a problem hiding this comment.
Testing on emulator with API 24 passes.
EmmanuelMess
enabled auto-merge
November 12, 2026 20:32
Member
|
Please use the "Fixes #..." text in your PR description to auto close the related issue. |
Contributor
Author
|
Thanks for reviewing and testing the PR! Appreciate the quick feedback and
approval. Glad to hear it passes on API 24.
|
Contributor
Author
|
Thanks, Emmanuel! Appreciate the review and quick merge. I'll make sure to
use the Fixes #... convention in future PRs.
Also, are there any other open issues or areas in the project that
currently need attention? I'd be interested in picking up another issue and
contributing further.
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The parent-directory (
..) navigation entry was not visible when opening an empty directory.Root Cause
The empty-state visibility check was executed before the parent-directory entry was inserted into the list. This caused the RecyclerView to be hidden even when the navigation entry was available.
Solution
Moved the empty-state visibility check to execute after inserting the parent-directory entry.
This ensures that empty directories can display the
..navigation entry while preserving the existing empty-state behavior when no list elements are available.Testing