Skip to content

Fix parent directory entry visibility in empty folders - #4777

Merged
EmmanuelMess merged 1 commit into
TeamAmaze:release/4.0from
amandeep25100-a11y:fix-empty-folder-parent-navigation
Nov 12, 2026
Merged

EmmanuelMess merged 1 commit into
TeamAmaze:release/4.0from
amandeep25100-a11y:fix-empty-folder-parent-navigation

Conversation

@amandeep25100-a11y

Copy link
Copy Markdown
Contributor

Problem

The parent-directory (..) navigation entry was not visible when opening an empty directory.

Root Cause

The empty-state visibility check was executed before the parent-directory entry was inserted into the list. This caused the RecyclerView to be hidden even when the navigation entry was available.

Solution

Moved the empty-state visibility check to execute after inserting the parent-directory entry.

This ensures that empty directories can display the .. navigation entry while preserving the existing empty-state behavior when no list elements are available.

Testing

  • Built and installed the F-Droid debug variant.
  • Verified the navigation entry's visibility in Grid View.
  • Verified the change on a physical Android device.

Copilot AI balanced review requested due to automatic review settings November 12, 2026 07:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@EmmanuelMess EmmanuelMess added PR-Code-Review-Passed The human code review has passed for this PR. PR-Manual-Testing-Passed The manual tests, performed by a human on a working build of this PR, passed for this PR. labels Nov 12, 2026

@EmmanuelMess EmmanuelMess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on emulator with API 24 passes.

@EmmanuelMess

Copy link
Copy Markdown
Member

Please use the "Fixes #..." text in your PR description to auto close the related issue.

@EmmanuelMess
EmmanuelMess merged commit d82b75d into TeamAmaze:release/4.0 Nov 12, 2026
5 checks passed
@amandeep25100-a11y

amandeep25100-a11y commented Nov 12, 2026 via email •

Copy link
Copy Markdown
Contributor Author

@amandeep25100-a11y

amandeep25100-a11y commented Nov 12, 2026 via email •

Copy link
Copy Markdown
Contributor Author

@EmmanuelMess

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Code-Review-Passed The human code review has passed for this PR. PR-Manual-Testing-Passed The manual tests, performed by a human on a working build of this PR, passed for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants