Skip to content

Add logging to extractor #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
absurdlylongusername wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add logging to extractor #1403

absurdlylongusername wants to merge 3 commits into from

Conversation

@absurdlylongusername
Copy link
Member

@absurdlylongusername absurdlylongusername commented Nov 16, 2025 •
edited
Loading

Adds a logging API to the Extractor.
By default it logs nothing, and users of the extractor can use setLogger to define where logs are written.

Uses ConsoleLogger for all tests by default using JUnit 5 extensions

Added some initial logs to some places.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Related PR: #1325

@absurdlylongusername
Add logging functionality to extractor and add some logging
820825e 
Set ConsoleLogger globally for all tests
@absurdlylongusername
Fix null exception in tests
25b04f2 
Add string formatting to logger
Add tests for logger formatting
@absurdlylongusername absurdlylongusername linked an issue Nov 20, 2025 that may be closed by this pull request
Add initial logging framework to the extractor #1407
Open
5 tasks
@absurdlylongusername absurdlylongusername mentioned this pull request Nov 20, 2025
Open
3 tasks
@TobiGr TobiGr added codequality Improvements to the codebase to improve the code quality tests Issues and PR related to unit tests meta Related to the project but not strictly to code labels Nov 28, 2025
TobiGr
TobiGr reviewed Nov 28, 2025
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should however add some documentation

  • to the ExtractorLogger class
  • on how to set the logger
  • somehwere on how to disable the JUnit logger extension

extractor/src/main/java/org/schabi/newpipe/extractor/utils/ExtractorLogger.java
@@ -0,0 +1,193 @@
package org.schabi.newpipe.extractor.utils;

public final class ExtractorLogger {
Copy link
Contributor

@TobiGr TobiGr Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lines of class doc would be good to have here.

@absurdlylongusername absurdlylongusername removed the meta Related to the project but not strictly to code label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

codequality Improvements to the codebase to improve the code quality tests Issues and PR related to unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add initial logging framework to the extractor

2 participants

@absurdlylongusername @TobiGr