Merge pull request #257 from TelemetryDeck/fix/254-invalid-service-url

Fix: keep trailing slash as required by the ingestion API

Author: kkostov

.github/workflows/ci.yaml

@@ -27,7 +27,7 @@ jobs:
         xcode:
           - "26"
         xcodebuildCommand:
-          - "-sdk iphonesimulator -destination 'platform=iOS Simulator,OS=26.0.1,name=iPhone 17'"
+          - "-sdk iphonesimulator -destination 'platform=iOS Simulator,OS=26.1,name=iPhone 17'"
           - "-sdk macosx -destination 'platform=macOS'"
           - "-sdk xrsimulator -destination 'platform=visionOS Simulator,OS=26.0,name=Apple Vision Pro'"
           - "-sdk appletvsimulator -destination 'platform=tvOS Simulator,OS=26.0,name=Apple TV 4K (3rd generation)'"

Sources/TelemetryDeck/Signals/SignalManager.swift

@@ -262,15 +262,13 @@ extension SignalManager {
 extension SignalManager {
     private func send(_ signalPostBodies: [SignalPostBody], completionHandler: @escaping @Sendable (Data?, URLResponse?, Error?) -> Void) {
         DispatchQueue.global(qos: .utility).async {
-            let url: URL
-            if let namespace = self.configuration.namespace, !namespace.isEmpty {
-                url = self.configuration.apiBaseURL
-                    .appendingPathComponent("v2")
-                    .appendingPathComponent("namespace")
-                    .appendingPathComponent(namespace)
-            } else {
-                url = self.configuration.apiBaseURL
-                    .appendingPathComponent("v2")
+            guard let url = SignalManager.getServiceUrl(baseURL: self.configuration.apiBaseURL, namespace: self.configuration.namespace) else {
+                self.configuration.logHandler?.log(
+                    .error,
+                    message: "Unable to construct signal API URL for namespace \(self.configuration.namespace ?? "nil")"
+                )
+                DispatchQueue.main.async { completionHandler(nil, nil, TelemetryError.invalidEndpointUrl) }
+                return
             }
 
             var urlRequest = URLRequest(url: url)
@@ -291,6 +289,21 @@ extension SignalManager {
             task.resume()
         }
     }
+
+    static func getServiceUrl(baseURL: URL, namespace: String? = nil) -> URL? {
+        let path =
+            if let namespace = namespace, !namespace.isEmpty {
+                "/v2/namespace/\(namespace)/"
+            } else {
+                "/v2/"
+            }
+
+        guard let serviceURL = URL(string: path, relativeTo: baseURL)?.standardized else {
+            return nil
+        }
+
+        return serviceURL
+    }
 }
 
 // MARK: - Helpers
@@ -364,6 +377,7 @@ private enum TelemetryError: Error {
     case forbidden
     case payloadTooLarge
     case invalidStatusCode(statusCode: Int)
+    case invalidEndpointUrl
 }
 
 extension TelemetryError: LocalizedError {
@@ -377,6 +391,8 @@ extension TelemetryError: LocalizedError {
             return "Forbidden (403)"
         case .payloadTooLarge:
             return "Payload is too large (413)"
+        case .invalidEndpointUrl:
+            return "Invalid endpoint URL"
         }
     }
 }

Sources/TelemetryDeck/TelemetryClient.swift

@@ -10,7 +10,7 @@ import Foundation
     import TVUIKit
 #endif
 
-let sdkVersion = "2.9.7"
+let sdkVersion = "2.9.8"
 
 /// Configuration for TelemetryManager
 ///

Tests/TelemetryDeckTests/TelemetryClientTests.swift

@@ -0,0 +1,34 @@
+//
+//  TelemetryClientTests.swift
+//  TelemetryDeck
+//
+//  Created by Konstantin on 17/11/2025.
+//
+
+import Foundation
+import Testing
+
+@testable import TelemetryDeck
+
+struct TelemetryClientTests {
+
+    @Test
+    func `SignalManager creates correct service url`() {
+
+        let config = TelemetryManagerConfiguration(appID: "44e0f59a-60a2-4d4a-bf27-1f96ccb4aaa3")
+        let result = SignalManager.getServiceUrl(baseURL: config.apiBaseURL)
+
+        #expect(result != nil)
+        #expect(result?.absoluteString == "https://nom.telemetrydeck.com/v2/")
+    }
+
+    @Test
+    func `SignalManager creates correct service url with namespace`() {
+
+        let config = TelemetryManagerConfiguration(appID: "44e0f59a-60a2-4d4a-bf27-1f96ccb4aaa3")
+        let result = SignalManager.getServiceUrl(baseURL: config.apiBaseURL, namespace: "deltaquadrant")
+
+        #expect(result != nil)
+        #expect(result?.absoluteString == "https://nom.telemetrydeck.com/v2/namespace/deltaquadrant/")
+    }
+}