From 982e541a562adf68aad82d3df680a17e895bb0b4 Mon Sep 17 00:00:00 2001
From: hgarrereyn <harrisonmichaelgreen@gmail.com>
Date: Sun, 1 Feb 2026 22:06:54 -0500
Subject: [PATCH] Updated SFileGetFileName to use StringCopy for safer string
 handling and added a comment to clarify szFileName requirements.

---
 src/SFileGetFileInfo.cpp | 2 +-
 src/StormLib.h           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/SFileGetFileInfo.cpp b/src/SFileGetFileInfo.cpp
index 3c05e13..ba6da77 100644
--- a/src/SFileGetFileInfo.cpp
+++ b/src/SFileGetFileInfo.cpp
@@ -602,7 +602,7 @@ bool WINAPI SFileGetFileName(HANDLE hFile, char * szFileName)
                 // Copy the file name to the output buffer, if any
                 if(pFileEntry->szFileName && szFileName)
                 {
-                    strcpy(szFileName, pFileEntry->szFileName);
+                    StringCopy(szFileName, MAX_PATH, pFileEntry->szFileName);
                     dwErrCode = ERROR_SUCCESS;
                 }
             }
diff --git a/src/StormLib.h b/src/StormLib.h
index 1eb2de3..2c407de 100644
--- a/src/StormLib.h
+++ b/src/StormLib.h
@@ -1074,7 +1074,7 @@ bool   WINAPI SFileCloseFile(HANDLE hFile);
 
 // Retrieving info about a file in the archive
 bool   WINAPI SFileGetFileInfo(HANDLE hMpqOrFile, SFileInfoClass InfoClass, void * pvFileInfo, DWORD cbFileInfo, LPDWORD pcbLengthNeeded);
-bool   WINAPI SFileGetFileName(HANDLE hFile, char * szFileName);
+bool   WINAPI SFileGetFileName(HANDLE hFile, char * szFileName); // szFileName must be at least MAX_PATH chars
 bool   WINAPI SFileFreeFileInfo(void * pvFileInfo, SFileInfoClass InfoClass);
 
 // High-level extract function