chore: remove redundant font face override (#12160)

Author: vladitasev

packages/base/src/FontFace.ts

@@ -1,7 +1,6 @@
 import { hasStyle, createStyle } from "./ManagedStyles.js";
 import { getFeature } from "./FeaturesRegistry.js";
 import fontFaceCSS from "./generated/css/FontFace.css.js";
-import overrideFontFaceCSS from "./generated/css/OverrideFontFace.css.js";
 import type OpenUI5Support from "./features/OpenUI5Support.js";
 import { getDefaultFontLoading } from "./config/Fonts.js";
 
@@ -12,9 +11,6 @@ const insertFontFace = () => {
 	if ((!openUI5Support || !openUI5Support.isOpenUI5Detected())) {
 		insertMainFontFace();
 	}
-
-	// Always set the override font - OpenUI5 in CSS Vars mode does not set it, unlike the main font
-	insertOverrideFontFace();
 };
 
 const insertMainFontFace = () => {
@@ -29,10 +25,4 @@ const insertMainFontFace = () => {
 	}
 };
 
-const insertOverrideFontFace = () => {
-	if (!hasStyle("data-ui5-font-face-override")) {
-		createStyle(overrideFontFaceCSS, "data-ui5-font-face-override");
-	}
-};
-
 export default insertFontFace;

packages/base/src/css/MultipleDragGhost.css

@@ -5,7 +5,7 @@
     display: flex;
     color: var(--sapList_TextColor);
     background-color: var(--sapList_Background);
-    font-family: "72override", var(--sapFontFamily);
+    font-family: var(--sapFontFamily);
     height: var(--sapElement_LineHeight);
     border-bottom: var(--sapList_BorderWidth) solid var(--sapList_BorderColor);
     /* drag and drop related */

packages/base/src/css/OverrideFontFace.css

@@ -48,7 +48,7 @@
 .ui5-table-growing-row-subtext {
 	width: 100%;
 	text-align: center;
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 	white-space: nowrap;
 	overflow: hidden;
 	text-overflow: ellipsis;

packages/compat/src/themes/GrowingButton.css

@@ -36,7 +36,7 @@ table {
 .ui5-table-header-row {
 	color: var(--sapList_HeaderTextColor);
 	height: var(--ui5_table_header_row_height);
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 	font-size: var(--sapFontSize);
 	font-weight: var(--ui5_table_header_row_font_weight);
 	border-bottom: var(--ui5_table_header_row_border_width) solid var(--ui5_table_header_row_border_bottom_color);
@@ -59,7 +59,7 @@ tr {
 	justify-content: center;
 	text-align: center;
 	padding: 0.5rem 1rem;
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 	font-size: 0.875rem;
 	box-sizing: border-box;
 	color: var(--sapTextColor);

packages/compat/src/themes/Table.css

@@ -1,6 +1,6 @@
 :host {
 	display: table-cell;
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 	font-size: 0.875rem;
 	height: var(--ui5_table_row_height);
 	box-sizing: border-box;

packages/compat/src/themes/TableCell.css

@@ -14,7 +14,7 @@
 	border-width: var(--ui5_table_border_width);
 	background-color: var(--sapList_TableGroupHeaderBackground);
 	color: var(--sapList_TableGroupHeaderTextColor);
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 	font-size: var(--sapFontSize);
 	font-weight: var(--ui5_table_group_row_font-weight);
 }

packages/compat/src/themes/TableGroupRow.css

@@ -76,7 +76,7 @@
 
 .ui5-table-row-popin-title {
 	color: var(--sapContent_LabelColor);
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 	font-size: var(--sapFontSize);
 }
 

packages/compat/src/themes/TableRow.css

@@ -19,7 +19,7 @@
 }
 
 ::slotted([ui5-navigation-menu-item]) {
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 }
 
 :host([design="Action"]) {

packages/fiori/src/themes/NavigationMenuItem.css

@@ -68,7 +68,7 @@
 
 .ui5-nli-group-title-text {
 	color: var(--sapGroup_TitleTextColor);
-	font-family: "72override", var(--sapFontFamily);
+	font-family: var(--sapFontFamily);
 	font-size: var(--sapFontHeader5Size);
 	font-weight: bold;
 	white-space: nowrap;