refactor(ui5-rating-indicator): allow deselecting rating by clicking the same star (#12180)

Author: StefanDimitrov04

packages/main/cypress/specs/RatingIndicator.cy.tsx

@@ -275,5 +275,29 @@ describe("RatingIndicator", () => {
 
 			cy.get("@changeEvent").should("have.callCount", 17);
 		});
+
+		it("Second click on same star clears the RatingIndicator value", () => {
+			cy.mount(
+				<RatingIndicator></RatingIndicator>
+			);
+
+			cy.get("[ui5-rating-indicator")
+				.shadow()
+				.find("li")
+				.eq(3)
+				.as("star");
+
+			cy.get("@star")
+				.realClick();
+
+			cy.get("[ui5-rating-indicator")
+				.should("have.attr", "value", 4);
+
+			cy.get("@star")
+				.realClick();
+
+			cy.get("[ui5-rating-indicator]")
+				.should("have.attr", "value", 0);
+		})
 	});
 });

packages/main/src/RatingIndicator.ts

@@ -237,8 +237,7 @@ class RatingIndicator extends UI5Element {
 
 		if (targetValue !== null) {
 			this.value = parseInt(targetValue);
-
-			if (this.value === 1 && this._liveValue === 1) {
+			if (this.value === this._liveValue) {
 				this.value = 0;
 			}