quality-debt: inc/models/class-site.php — PR #1125 review feedback (medium)

[superdav42]

Unactioned Review Feedback

Source PR: #1125
File: inc/models/class-site.php
Reviewers: coderabbit
Findings: 1
Max severity: medium

---

MEDIUM: coderabbit (coderabbitai[bot])

File: inc/models/class-site.php:1783
🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win

Return a WP_Error from the exception path too.

This branch reintroduces a generic false failure mode, so callers still cannot handle all delete failures uniformly. Wrapping the caught throwable in a translated WP_Error keeps delete() consistent with the new wp_delete_site() error propagation.

💡 Proposed change

 		try {
 			$wp_result = wp_delete_site($this->get_id());
 		} catch (\Throwable $e) {
 			wu_log_add('fatal-error', $e->getMessage(), LogLevel::ERROR);

-			return false;
+			return new \WP_Error(
+				'wu_' . $this->model . '_delete_failed',
+				__('Failed to delete the site.', 'ultimate-multisite')
+			);
 		}

As per coding guidelines: 'Use WP_Error for validation and operation failures, not exceptions. Check is_wp_error() on return values.'

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@inc/models/class-site.php` around lines 1777 - 1783, The catch block in the
delete() method currently logs the throwable and returns false, reintroducing a
non-WP_Error failure mode; change it to return a WP_Error instead by creating a
new WP_Error (with a machine-readable code like 'site_delete_failed'), a
translated message including $e->getMessage(), and any useful data (e.g.,
'site_id' => $this->get_id()), after calling wu_log_add; update the catch block
around wp_delete_site($this->get_id()) so callers can use is_wp_error()
uniformly.

View comment

---

---

Auto-generated by quality-feedback-helper.sh scan-merged. Review each finding and either fix the code or dismiss with a reason.

---

aidevops.sh v3.14.75 automated scan.

[superdav42]

DISPATCH_CLAIM nonce=2ab4bc563439116f32675686c4b9aa51 runner=superdav42 ts=2026-05-06T11:03:36Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=96f07143dd86de77ce5b83a41738beda runner=superdav42 ts=2026-05-06T11:04:03Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=4969bd1e10b7190dc19665c8ead54fe2 runner=superdav42 ts=2026-05-06T11:11:58Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=266158e0181bf6ceacdc821343cebafe runner=superdav42 ts=2026-05-06T11:12:57Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=f5709638e36519bfd21af9b5324e3e24 runner=superdav42 ts=2026-05-06T11:16:06Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=462dddab2452c059ff4882164eb1911b runner=superdav42 ts=2026-05-06T11:17:43Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=5dbf8d04b0a3e0a2114ef8d3d6b1b948 runner=superdav42 ts=2026-05-06T11:21:35Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=40b63d38232e99f6c2c77e16c6b5d47a runner=superdav42 ts=2026-05-06T11:24:08Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33

[superdav42]

DISPATCH_CLAIM nonce=98dbea61de7ae4e74922d79cd52f6cc9 runner=superdav42 ts=2026-05-06T11:28:08Z max_age_s=1800 version=3.14.75 opencode_version=1.14.33