From 1bd9d4cdb403992d427f79fbf41cd0a5a3acee04 Mon Sep 17 00:00:00 2001
From: David Stone <david@nnucomputerwhiz.com>
Date: Tue, 14 Apr 2026 09:27:30 -0600
Subject: [PATCH] test: remove redundant unserialize() calls on get_post_meta()
 results (GH#839)

get_post_meta($id, $key, true) already applies maybe_unserialize() internally,
so calling unserialize() again on the returned value fails in PHP 8+ because the
value is already an array, not a serialized string.

Two remaining occurrences in verify_attachment_backfill() and
verify_elementor_backfill() were missed by commit dd3461d. This removes them,
completing the fix for all three instances flagged in PR #825 review.

Fixes #839
---
 tests/WP_Ultimo/Helpers/Site_Duplicator_Postmeta_Test.php | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/WP_Ultimo/Helpers/Site_Duplicator_Postmeta_Test.php b/tests/WP_Ultimo/Helpers/Site_Duplicator_Postmeta_Test.php
index 7f9b2888..c9573296 100644
--- a/tests/WP_Ultimo/Helpers/Site_Duplicator_Postmeta_Test.php
+++ b/tests/WP_Ultimo/Helpers/Site_Duplicator_Postmeta_Test.php
@@ -955,7 +955,7 @@ private function verify_nav_menu_backfill() {
 	private function verify_attachment_backfill() {
 		switch_to_blog($this->to_blog_id);
 		$this->assertEquals('2024/01/logo.png', get_post_meta($this->to_attachment_id, '_wp_attached_file', true));
-		$meta = unserialize(get_post_meta($this->to_attachment_id, '_wp_attachment_metadata', true));
+		$meta = get_post_meta($this->to_attachment_id, '_wp_attachment_metadata', true);
 		$this->assertIsArray($meta);
 		$this->assertEquals(200, $meta['width']);
 		$this->assertEquals('Site Logo', get_post_meta($this->to_attachment_id, '_wp_attachment_image_alt', true));
@@ -979,9 +979,7 @@ private function verify_elementor_backfill() {
 			'header',
 			get_post_meta($this->from_elementor_post_id, '_elementor_template_type', true)
 		);
-		$settings = unserialize(
-			get_post_meta($this->from_elementor_post_id, '_elementor_page_settings', true)
-		);
+		$settings = get_post_meta($this->from_elementor_post_id, '_elementor_page_settings', true);
 		$this->assertIsArray($settings);
 		$this->assertEquals('header', $settings['template']);
 		restore_current_blog();