Small refactor

`$` is a special snowflake; embrace it

Author: J-Fields

src/actions/baseMotion.ts

@@ -53,12 +53,6 @@ export abstract class BaseMovement extends BaseAction {
    */
   isRepeat = false;
 
-  /**
-   * This is for commands like $ which force the desired column to be at
-   * the end of even the longest line.
-   */
-  public setsDesiredColumnToEOL = false;
-
   protected selectionType = SelectionType.Concatenating;
 
   constructor(keysPressed?: string[], isRepeat?: boolean) {

src/actions/motion.ts

@@ -1085,9 +1085,8 @@ class MoveRepeatReversed extends BaseMovement {
 }
 
 @RegisterAction
-class MoveLineEnd extends BaseMovement {
+export class MoveLineEnd extends BaseMovement {
   keys = [['$'], ['<End>'], ['<D-right>']];
-  override setsDesiredColumnToEOL = true;
 
   public override async execActionWithCount(
     position: Position,

src/mode/modeHandler.ts

@@ -60,6 +60,7 @@ import {
   isVisualMode,
 } from './mode';
 import { DocumentContentChangeAction } from '../actions/commands/documentChange';
+import { MoveLineEnd } from '../actions/motion';
 
 interface IModeHandlerMap {
   get(editorId: Uri): ModeHandler | undefined;
@@ -862,7 +863,7 @@ export class ModeHandler implements vscode.Disposable, IModeHandler {
     if (!preservesDesiredColumn) {
       if (action instanceof BaseMovement) {
         // We check !operator here because e.g. d$ should NOT set the desired column to EOL.
-        if (action.setsDesiredColumnToEOL && !recordedState.operator) {
+        if (action instanceof MoveLineEnd && !recordedState.operator) {
           this.vimState.desiredColumn = Number.POSITIVE_INFINITY;
         } else {
           this.vimState.desiredColumn = this.vimState.cursorStopPosition.character;

src/textobject/textobject.ts

@@ -595,8 +595,6 @@ export class SelectEntireIgnoringLeadingTrailing extends TextObject {
 }
 
 abstract class IndentObjectMatch extends TextObject {
-  override setsDesiredColumnToEOL = true;
-
   protected includeLineAbove = false;
   protected includeLineBelow = false;