Crashing for specific function in Psuedo-C/Rust

[chainloaded]

Version and Platform (required):

• Binary Ninja Version: 5.1.8104 Personal, 6eaaf348
• OS: windows
• OS Version: 11
• CPU Architecture: x86_64

Bug Description:
When performing a search in Binary Ninja ("Find type: Text (Pseudo C)") in a specific binary, Binary Ninja crashes.

Steps To Reproduce:

• Open fvevol.sys in Windows 11 25H2 (26200).
• Open find window, select "Text (Pseudo C)" as Find type
• Search for " + 0x334"
• Crash at roughly 43% of the search

Expected Behavior:
Finishing the search without a crash.

Screenshots:

Binary:
https://msdl.microsoft.com/download/symbols/fvevol.sys/37057C75eb000/fvevol.sys

Additional Information:

[emesare]

This is a crash in the Psuedo-C/Psuedo-Rust language representation and can be caused by navigating to 0x1400679ed in the binary. The "find" operation causes the actual tokens to be rendered.

This is a regression caused by be78ae6

EDIT: Not a regression per say, the crash is caused by that line but it seems to still crash on older versions like 5.0/5.1 stable

Crashes here:

binaryninja-api/lang/c/pseudoc.cpp

Line 596 in be78ae6

&& arrayIndexExpr.GetType()->GetChildType()->GetWidth() < instr.size)