-
Notifications
You must be signed in to change notification settings - Fork 189
feat: added RCS suggestions, SMS/MMS updates and WhatsApp category #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
5567423 to
7013eb1
Compare
7013eb1 to
7fb016a
Compare
d70dc0d to
6bf7580
Compare
9371f94 to
be5a5fe
Compare
superchilled
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a couple of small things to fix and some suggestions. Also, I noticed that this doesn't have the RCS card and carousel types; are those going to be in a separate PR?
packages/messages/lib/types/Channels/RCS/Suggestions/RCSCreateCalendarEventSuggestionParams.ts
Show resolved
Hide resolved
packages/messages/lib/types/Channels/RCS/Suggestions/RCSCreateCalendarEventSuggestionParams.ts
Show resolved
Hide resolved
packages/messages/lib/classes/RCS/Suggestions/RCSCreateCalendarEventSuggestion.ts
Outdated
Show resolved
Hide resolved
packages/messages/lib/classes/RCS/Suggestions/RCSCreateCalendarEventSuggestion.ts
Outdated
Show resolved
Hide resolved
packages/messages/lib/classes/RCS/Suggestions/RCSOpenUrlWebviewSuggestion.ts
Outdated
Show resolved
Hide resolved
packages/messages/lib/types/Channels/RCS/Suggestions/RCSViewLocationParams.ts
Show resolved
Hide resolved
Co-authored-by: Karl Lingiah <[email protected]>
Co-authored-by: Karl Lingiah <[email protected]>
superchilled
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (assuming card and carousel are being added separately?)
Description
Motivation and Context
Testing Details
Example Output or Screenshots (if appropriate)
Types of changes
Checklist