Skip to content

Commit 191eb50

Browse files
committed
Stop all properties being removed by default
1 parent d2d2ee2 commit 191eb50

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

zwave-classifier.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -758,6 +758,9 @@ class ZWaveClassifier {
758758
if (name[0] == '_') {
759759
property.visible = false;
760760
}
761+
// Invisible properties are no longer exposed in Thing Descriptions so
762+
// should eventually be removed entirely.
763+
// See https://github.com/WebThingsIO/zwave-adapter/issues/140
761764
return property;
762765
}
763766

zwave-node.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,10 @@ class ZWaveNode extends Device {
7373
dict.zwClasses = this.zwClasses;
7474
dict.zwValues = this.zwValues;
7575

76+
// Remove invisible properties from the Thing Description
77+
// See https://github.com/WebThingsIO/zwave-adapter/issues/140
7678
for (const prop of Object.values(dict.properties)) {
77-
if (!prop.visible) {
79+
if (prop.hasOwnProperty('visible') && prop.visible === false) {
7880
delete dict.properties[prop.name];
7981
}
8082
}

0 commit comments

Comments
 (0)