device: only propagate roaming value before peer is referenced elsewhere

A peer.endpoint never becomes nil after being not-nil, so creation is
the only time we actually need to set this. This prevents a race from
when the variable is actually used elsewhere, and allows us to avoid an
expensive atomic.

Signed-off-by: Jason A. Donenfeld <[email protected]>

Author: zx2c4

device/uapi.go

@@ -261,7 +261,9 @@ func (peer *ipcSetPeer) handlePostConfig() {
 	if peer.Peer == nil || peer.dummy {
 		return
 	}
-	peer.disableRoaming = peer.device.net.brokenRoaming && peer.endpoint != nil
+	if peer.created {
+		peer.disableRoaming = peer.device.net.brokenRoaming && peer.endpoint != nil
+	}
 	if peer.device.isUp() {
 		peer.Start()
 		if peer.pkaOn {