Skip to content

Support LIKE/WHERE clauses in all SHOW statements #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

Support LIKE/WHERE clauses in all SHOW statements #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1d222a
Add support for LIKE and WHERE in SHOW COLLATION
JanJakes Nov 6, 2025
2142de2
Add support for WHERE clause in SHOW INDEX
JanJakes Nov 6, 2025
1d0bae7
Improve code structure and comments
JanJakes Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/WP_SQLite_Driver_Metadata_Tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,7 @@ public function testRepairTable() {
}

public function testShowCollation(): void {
// Simple.
$this->assertQuery( 'SHOW COLLATION' );
$actual = $this->engine->get_query_results();
$this->assertCount( 7, $actual );
Expand All @@ -478,6 +479,21 @@ public function testShowCollation(): void {
$this->assertEquals( 'utf8mb4_bin', $actual[4]->Collation );
$this->assertEquals( 'utf8mb4_unicode_ci', $actual[5]->Collation );
$this->assertEquals( 'utf8mb4_0900_ai_ci', $actual[6]->Collation );

// With LIKE clause.
$this->assertQuery( "SHOW COLLATION LIKE 'utf8%'" );
$actual = $this->engine->get_query_results();
$this->assertCount( 6, $actual );
$this->assertEquals( 'utf8_bin', $actual[0]->Collation );
$this->assertEquals( 'utf8_general_ci', $actual[1]->Collation );
$this->assertEquals( 'utf8_unicode_ci', $actual[2]->Collation );
$this->assertEquals( 'utf8mb4_bin', $actual[3]->Collation );

// With WHERE clause.
$this->assertQuery( "SHOW COLLATION WHERE Collation = 'utf8_bin'" );
$actual = $this->engine->get_query_results();
$this->assertCount( 1, $actual );
$this->assertEquals( 'utf8_bin', $actual[0]->Collation );
}

public function testShowDatabases(): void {
Expand Down
13 changes: 13 additions & 0 deletions tests/WP_SQLite_Driver_Tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3018,6 +3018,19 @@ public function testShowIndex() {
),
$this->engine->get_query_results()
);

// With WHERE clause.
$this->assertQuery( "SHOW INDEX FROM wptests_term_relationships WHERE Key_name = 'PRIMARY'" );
$actual = $this->engine->get_query_results();
$this->assertCount( 2, $actual );

$this->assertQuery( 'SHOW INDEX FROM wptests_term_relationships WHERE Non_unique = 0' );
$actual = $this->engine->get_query_results();
$this->assertCount( 2, $actual );

$this->assertQuery( "SHOW INDEX FROM wptests_term_relationships WHERE Index_type = 'FULLTEXT'" );
$actual = $this->engine->get_query_results();
$this->assertCount( 2, $actual );
}

public function testShowVarianles(): void {
Expand Down
38 changes: 26 additions & 12 deletions wp-includes/sqlite-ast/class-wp-sqlite-driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,7 +2230,7 @@ private function execute_show_statement( WP_Parser_Node $node ): void {

switch ( $keyword1->id ) {
case WP_MySQL_Lexer::COLLATION_SYMBOL:
$this->execute_show_collation_statement();
$this->execute_show_collation_statement( $node );
return;
case WP_MySQL_Lexer::DATABASES_SYMBOL:
$this->execute_show_databases_statement( $node );
Expand Down Expand Up @@ -2359,12 +2359,18 @@ private function execute_show_statement( WP_Parser_Node $node ): void {

/**
* Translate and execute a MySQL SHOW COLLATION statement in SQLite.
*
* @param WP_Parser_Node $node The "showStatement" AST node.
*/
private function execute_show_collation_statement(): void {
private function execute_show_collation_statement( WP_Parser_Node $node ): void {
$definition = $this->information_schema_builder
->get_computed_information_schema_table_definition( 'collations' );

// TODO: LIKE and WHERE clauses.
// LIKE and WHERE clauses.
$like_or_where = $node->get_first_child_node( 'likeOrWhere' );
if ( $like_or_where ) {
$condition = $this->translate_show_like_or_where_condition( $like_or_where, 'collation_name' );
}

$stmt = $this->execute_sqlite_query(
sprintf(
Expand All @@ -2376,8 +2382,10 @@ private function execute_show_collation_statement(): void {
IS_COMPILED AS `Compiled`,
SORTLEN AS `Sortlen`,
PAD_ATTRIBUTE AS `Pad_attribute`
FROM (%s)',
$definition
FROM (%s)
WHERE TRUE %s',
$definition,
$condition ?? ''
)
);
$this->store_last_column_meta_from_statement( $stmt );
Expand All @@ -2394,10 +2402,9 @@ private function execute_show_databases_statement( WP_Parser_Node $node ): void

// LIKE and WHERE clauses.
$like_or_where = $node->get_first_child_node( 'likeOrWhere' );
if ( null !== $like_or_where ) {
if ( $like_or_where ) {
$condition = $this->translate_show_like_or_where_condition( $like_or_where, 'schema_name' );
}

$stmt = $this->execute_sqlite_query(
sprintf(
'SELECT SCHEMA_NAME AS Database
Expand All @@ -2424,10 +2431,9 @@ private function execute_show_databases_statement( WP_Parser_Node $node ): void
* @param WP_Parser_Node $node The "showStatement" AST node.
*/
private function execute_show_index_statement( WP_Parser_Node $node ): void {
// Get database and table name.
$table_ref = $node->get_first_child_node( 'tableRef' );
$in_db = $node->get_first_child_node( 'inDb' );

// Get database and table name.
if ( $in_db ) {
// FROM/IN database.
$database = $this->get_database_name( $in_db );
Expand All @@ -2436,7 +2442,14 @@ private function execute_show_index_statement( WP_Parser_Node $node ): void {
}
$table_name = $this->unquote_sqlite_identifier( $this->translate( $table_ref ) );

// TODO: WHERE
// WHERE clause.
$where = $node->get_first_child_node( 'whereClause' );
if ( null !== $where ) {
$value = $this->translate( $where->get_first_child_node( 'expr' ) );
$condition = sprintf( 'AND %s', $value );
} else {
$condition = '';
}

$table_is_temporary = $this->information_schema_builder->temporary_table_exists( $table_name );

Expand Down Expand Up @@ -2480,6 +2493,7 @@ private function execute_show_index_statement( WP_Parser_Node $node ): void {
FROM ' . $this->quote_sqlite_identifier( $statistics_table ) . "
WHERE table_schema = ?
AND table_name = ?
$condition
ORDER BY
INDEX_NAME = 'PRIMARY' DESC,
NON_UNIQUE = '0' DESC,
Expand Down Expand Up @@ -2624,10 +2638,10 @@ private function execute_show_tables_statement( WP_Parser_Node $node ): void {
*/
private function execute_show_columns_statement( WP_Parser_Node $node ): void {
// TODO: EXTENDED, FULL
$table_ref = $node->get_first_child_node( 'tableRef' );
$in_db = $node->get_first_child_node( 'inDb' );

// Get database and table name.
$table_ref = $node->get_first_child_node( 'tableRef' );
$in_db = $node->get_first_child_node( 'inDb' );
if ( $in_db ) {
// FROM/IN database.
$database = $this->get_database_name( $in_db );
Expand Down
Loading