Merge pull request #47 from WorldBank-Transport/develop

Release ram-analysis v0.3.0

Author: olafveerman

ram-analysis/app/calculate-eta/index.js

@@ -31,8 +31,13 @@ process.on('message', function (e) {
   try {
     init(e);
   } catch (err) {
-    process.send({type: 'error', data: err.message, stack: err.stack});
-    throw err;
+    process.send({
+      type: 'error',
+      data: err.message,
+      stack: err.stack,
+      details: err.details
+    });
+    process.exit(1);
   }
 });
 

ram-analysis/app/calculate-eta/tasks.js

@@ -71,7 +71,18 @@ export function createProcessAreaTask (workArea, poiByType, origins, osrm, maxTi
       let minPoi = Math.min(totalPoi, 4);
       process.send({type: 'debug', data: `Total poi of type ${key}: ${totalPoi}`, id: id});
       do {
-        poiSet = poisInBuffer(workArea, poiByType[key], time, speed);
+        // There may be situation where no points are found in the buffer even
+        // though it encompasses the whole world. In this case it throw an error
+        // Add some details to the error.
+        try {
+          poiSet = poisInBuffer(workArea, poiByType[key], time, speed);
+        } catch (err) {
+          if (err.message === 'World buffer overflow') {
+            err.details = `There are a total of ${totalPoi} pois of type "${key}" but none were found in the full world buffer.
+    This may mean that the poi coordinates system is not in the EPSG:4326 (WGS84) projection.`;
+          }
+          throw err;
+        }
         time += 900;
       } while (poiSet.features.length < minPoi);
       process.send({type: 'debug', data: `Using ${poiSet.features.length} pois. Time: ${time - 900}`, id: id});

ram-analysis/app/calculate-eta/utils.js

@@ -2,6 +2,7 @@
 import { featureCollection } from '@turf/helpers';
 import within from '@turf/within';
 import buffer from '@turf/buffer';
+import bbox from '@turf/bbox';
 
 /**
  * Create an array filled with a range of numbers starting at {start} and ending
@@ -13,7 +14,7 @@ import buffer from '@turf/buffer';
  */
 export function range (start, end) {
   let res = [];
-  for (var i = start; i < end; i++) { res.push(i); }
+  for (let i = start; i < end; i++) { res.push(i); }
   return res;
 }
 
@@ -25,7 +26,7 @@ export function range (start, end) {
  *   Origins in the given area
  */
 export function originsInRegion (area, origins) {
-  let result = within(origins, featureCollection([area]));
+  const result = within(origins, featureCollection([area]));
   return result;
 }
 
@@ -37,12 +38,21 @@ export function originsInRegion (area, origins) {
  * @param  {number} time    Value in seconds
  * @param  {number} speed   Value in km/h
  * @param  {FeatureCollection} poi     Points of Interest
+ *
+ * @throws RangeError
+ *
  * @return {FeatureCollection}
  *   The Points of Interest in the buffered area.
  */
 export function poisInBuffer (area, poi, time, speed) {
-  let distance = (time / 3600) * speed;
-  let bufferedArea = buffer(area, distance, 'kilometers');
-  var result = within(poi, featureCollection([bufferedArea]));
+  const distance = (time / 3600) * speed;
+  const bufferedArea = buffer(area, distance, 'kilometers');
+  const [e, s, w, n] = bbox(bufferedArea);
+
+  if (e < -180 && w > 180 && s < -85 && n > 85) {
+    throw new RangeError('World buffer overflow');
+  }
+
+  const result = within(poi, featureCollection([bufferedArea]));
   return result;
 }