Skip to content

Commit 3ecb9fc

Browse files
authored
Merge pull request #335 from WyriHaximusNet/make-sure-after-removing-PHPIZE_DEPS-we-still-have-git-and-make
Make sure after removing $PHPIZE_DEPS we still have git and make
2 parents f30c24c + 7c2035d commit 3ecb9fc

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

Dockerfile-nts-alpine

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ RUN EXTENSION_DIR=`php-config --extension-dir 2>/dev/null` && \
8888
&& docker-php-ext-enable --ini-name zzzzz-event.ini event \
8989
&& docker-php-ext-enable uv \
9090
&& apk del $PHPIZE_DEPS \
91+
&& apk add --no-cache make git \
9192
&& wget -q -O - https://raw.githubusercontent.com/eficode/wait-for/master/wait-for > /bin/wait-for \
9293
&& chmod +x /bin/wait-for \
9394
&& rm -rf /var/cache/apk/* \

Dockerfile-zts-alpine

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ RUN EXTENSION_DIR=`php-config --extension-dir 2>/dev/null` && \
9393
&& docker-php-ext-enable --ini-name zzzzz-event.ini event \
9494
&& docker-php-ext-enable uv \
9595
&& apk del $PHPIZE_DEPS \
96+
&& apk add --no-cache make git \
9697
&& wget -q -O - https://raw.githubusercontent.com/eficode/wait-for/master/wait-for > /bin/wait-for \
9798
&& chmod +x /bin/wait-for \
9899
&& rm -rf /var/cache/apk/* \

test/container/test_in_docker.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ def test_in_docker_file_exists(host):
1111
output = host.run('php -r "exit(file_exists(\'/.you-are-in-a-wyrihaximus.net-php-docker-image-dev\') ? 0 : 255);"')
1212
assert output.rc == 0
1313

14-
@pytest.mark.php_dev
14+
@pytest.mark.php_zts
15+
@pytest.mark.php_nts
1516
def test_make_works(host):
1617
output = host.run('make')
1718
assert output.stdout == ''

0 commit comments

Comments
 (0)