Fix PCM destructor 'segfault'

PCM module used to segfaults after 0.4.4 because the added destructor missed a case when the buffer is loaded directly instead from a file or converted.

Author: Youjose

CriCodecs/pcm.cpp

@@ -385,6 +385,7 @@ struct PCM{
     double        *PCM_IEEE_64; /* 64 float bits */
     unsigned int ColumnSize;
     bool converted;
+    bool loaded;
     riff wav;
 
     PCM(){
@@ -397,10 +398,11 @@ struct PCM{
         PCM_IEEE_64 = NULL;
         wav = {};
         converted = false;
+        loaded = false;
     }
 
     ~PCM(){
-        if(WAVEBuffer != NULL)
+        if(WAVEBuffer != NULL && !loaded)
             delete[] WAVEBuffer;
         if(PCM_16 != NULL && converted)
             delete[] PCM_16;
@@ -543,6 +545,7 @@ struct PCM{
     }
 
     unsigned char* GetWaveBuffer(unsigned int SampleCount, unsigned int Channels, unsigned int SampleRate, bool Looping){
+        loaded = false;
         unsigned int header_size = Looping ? 0x70 : 0x2C;
         wav.size = header_size + SampleCount * Channels * sizeof(short);
         WAVEBuffer = new unsigned char[wav.size];
@@ -554,6 +557,7 @@ struct PCM{
 
     /* This function should not be used for files over 2GB in size. */
     char LoadFromFile(const char* Filename){
+        loaded = false;
         FILE* fp = fopen(Filename, "rb");
         fseek(fp, 0, 2);
         long long size = ftell(fp);
@@ -568,8 +572,8 @@ struct PCM{
         return load();
     }
 
-    /* the given buffer will be called by delete[] after the object distructs. */
     char LoadDirect(unsigned char* Buffer){
+        loaded = true;
         WAVEBuffer = Buffer;
         return load();
     }

CriCodecs/setup.py

@@ -2,6 +2,6 @@
 
 setup(
     name="CriCodecs",
-    version="0.2.2",
+    version="0.2.3",
     ext_modules=[Extension('CriCodecs', ["adx.cpp", "CriCodecs.cpp", "crilayla.cpp", "hca.cpp"])]
 )

setup.py

@@ -3,7 +3,7 @@
 
 setup(
     name="PyCriCodecs",
-    version="0.4.5",
+    version="0.4.6",
     description="Python frontend with a C++ backend of managing Criware files of all kinds.",
     packages=["PyCriCodecs"],
     ext_modules=[Extension('CriCodecs', ["CriCodecs\\CriCodecs.cpp"], include_dirs=[os.path.realpath("CriCodecs")])]