Commit acdc0de
authored
fix: return entire history when history_length=0 (#537)
# Description
The specification states that a history length of 0 should return
unlimited results (see
[code](https://github.com/a2aproject/A2A/blob/202aa069e66f701bacf2156d42d8916fc96a5188/specification/grpc/a2a.proto#L128-L130)).
However, this was recently changed to return 0 results. This fix
restores the correct behavior.
Please note that there is an outstanding proposal to change this
behavior. See a2aproject/A2A#1071 for more
details.
Prerequisites:
- [x] Follow the [`CONTRIBUTING`
Guide](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [x] Ensure the tests and linter pass (Run `bash scripts/format.sh`
from the repository root to format)
- [x] Appropriate docs were updated (if necessary)
Fixes #<issue_number_goes_here> 🦕1 parent 45ff871 commit acdc0de
File tree
2 files changed
+15
-11
lines changed- src/a2a/utils
- tests/server/request_handlers
2 files changed
+15
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | | - | |
| 88 | + | |
91 | 89 | | |
92 | 90 | | |
93 | 91 | | |
| |||
Lines changed: 13 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
834 | 834 | | |
835 | 835 | | |
836 | 836 | | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
837 | 842 | | |
838 | 843 | | |
839 | 844 | | |
| |||
855 | 860 | | |
856 | 861 | | |
857 | 862 | | |
858 | | - | |
| 863 | + | |
859 | 864 | | |
860 | 865 | | |
861 | 866 | | |
| |||
866 | 871 | | |
867 | 872 | | |
868 | 873 | | |
869 | | - | |
| 874 | + | |
870 | 875 | | |
871 | 876 | | |
872 | 877 | | |
873 | 878 | | |
874 | 879 | | |
875 | | - | |
| 880 | + | |
876 | 881 | | |
877 | 882 | | |
878 | 883 | | |
879 | | - | |
| 884 | + | |
880 | 885 | | |
881 | 886 | | |
882 | 887 | | |
| |||
892 | 897 | | |
893 | 898 | | |
894 | 899 | | |
895 | | - | |
| 900 | + | |
| 901 | + | |
896 | 902 | | |
897 | 903 | | |
898 | 904 | | |
| |||
904 | 910 | | |
905 | 911 | | |
906 | 912 | | |
907 | | - | |
| 913 | + | |
908 | 914 | | |
909 | 915 | | |
910 | 916 | | |
911 | 917 | | |
912 | 918 | | |
913 | 919 | | |
914 | | - | |
| 920 | + | |
915 | 921 | | |
916 | 922 | | |
917 | 923 | | |
| |||
0 commit comments