Added room reactions tests.

Author: maratal

Sources/AblyChat/DefaultRoomReactions.swift

@@ -78,6 +78,11 @@ internal final class DefaultRoomReactions: RoomReactions, EmitsDiscontinuities {
                     subscription.emit(reaction)
                 } catch {
                     logger.log(message: "Error processing incoming reaction message: \(error)", level: .error)
+                    #if DEBUG
+                        for subscription in self.malformedMessageSubscriptions {
+                            subscription.emit(message)
+                        }
+                    #endif
                 }
             }
         }
@@ -97,4 +102,16 @@ internal final class DefaultRoomReactions: RoomReactions, EmitsDiscontinuities {
     private enum RoomReactionsError: Error {
         case noReferenceToSelf
     }
+
+    #if DEBUG
+        /// Subscription of malformed message events for testing purposes.
+        private var malformedMessageSubscriptions: [Subscription<ARTMessage>] = []
+
+        /// Returns a subscription which emits malformed message events for testing purposes.
+        internal func testsOnly_subscribeToMalformedMessageEvents() -> Subscription<ARTMessage> {
+            let subscription = Subscription<ARTMessage>(bufferingPolicy: .unbounded)
+            malformedMessageSubscriptions.append(subscription)
+            return subscription
+        }
+    #endif
 }

Tests/AblyChatTests/DefaultRoomReactionsTests.swift

@@ -43,22 +43,56 @@ struct DefaultRoomReactionsTests {
         #expect(channel.lastMessagePublishedExtras as? Dictionary == ["headers": ["someHeadersKey": "someHeadersValue"]])
     }
 
-    // @spec CHA-ER4
+    // @spec CHA-ER4a
     @Test
-    func subscribe_returnsSubscription() async throws {
-        // all setup values here are arbitrary
+    func subscriptionCanBeRegisteredToReceiveReactionEvents() async throws {
         // Given
-        let channel = MockRealtimeChannel(name: "basketball::$chat::$reactions")
+        let channel = MockRealtimeChannel(
+            messageJSONToEmitOnSubscribe: [
+                "name": "roomReaction",
+                "clientId": "who-sent-the-message",
+                "data": [
+                    "type": ":like:",
+                    "metadata": [
+                        "foo": "bar",
+                    ],
+                ],
+                "timestamp": "1726232498871",
+                "extras": [
+                    "headers": [
+                        "baz": "qux",
+                    ],
+                ],
+            ] as? [String: any Sendable]
+        )
         let featureChannel = MockFeatureChannel(channel: channel)
+        let defaultRoomReactions = await DefaultRoomReactions(featureChannel: featureChannel, clientID: "mockClientId", roomID: "basketball", logger: TestLogger())
 
         // When
+        let reactionSubscription = await defaultRoomReactions.subscribe()
+
+        // Then
+        let reaction = try #require(await reactionSubscription.first { _ in true })
+        #expect(reaction.type == ":like:")
+    }
+
+    // CHA-ER4c is currently untestable due to not subscribing to those events on lower level
+    // @spec CHA-ER4d
+    @Test
+    func malformedRealtimeEventsShallNotBeEmittedToSubscribers() async throws {
+        // Given
+        let channel = MockRealtimeChannel(
+            messageJSONToEmitOnSubscribe: ["foo": "bar"] // malformed realtime message
+        )
+        let featureChannel = MockFeatureChannel(channel: channel)
         let defaultRoomReactions = await DefaultRoomReactions(featureChannel: featureChannel, clientID: "mockClientId", roomID: "basketball", logger: TestLogger())
 
         // When
-        let subscription: Subscription<Reaction>? = await defaultRoomReactions.subscribe()
+        let malformedMessagesSubscription = await defaultRoomReactions.testsOnly_subscribeToMalformedMessageEvents()
+        _ = await defaultRoomReactions.subscribe()
 
         // Then
-        #expect(subscription != nil)
+        _ = try #require(await malformedMessagesSubscription.first { _ in true })
     }
 
     // @spec CHA-ER5