Skip to content

Commit bfbf98c

Browse files
bokelleyclaude
andcommitted
docs(migration): note 161 figure is v4.0 worst case (#520)
Salesagent re-run against v4.3+ (after expanded aliases + smaller-cascade warning) hit 141 findings and ~36 collection errors — markedly fewer. The 161 number gets quoted as if it's still representative; this callout points adopters at what to expect on v4.3+ while preserving the worst-case framing for adopters copying salesagent's pre-v4.3 pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 6869976 commit bfbf98c

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

MIGRATION_v3_to_v4.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,15 @@ the whole codebase. salesagent re-exported through `src/core/schemas/_base.py`
5656
during pytest collect-only**, and stubbing it revealed the next ~140-test
5757
cascade from `BrandManifest`, then the next from the `generated_poc` reach-ins.
5858

59+
> **The 161 figure is the worst case at v4.0 release.** A salesagent
60+
> re-run against v4.3+ (after expanded type aliases, `pending_activation`
61+
> codemod flagger, and the smaller-blast-radius
62+
> `_base.py`-cascade-warning landed) hit 141 codemod findings and ~36
63+
> collection errors — markedly less than the worst-case framing above.
64+
> Expect the lower number on v4.3+ checkouts; the worst-case story is
65+
> preserved here so adopters who copy salesagent's pre-v4.3 pattern know
66+
> what to triage first.
67+
5968
The codemod's static finding count understates this by 100x+. To minimize the
6069
felt blast radius, work in this order:
6170

0 commit comments

Comments
 (0)