test(examples): create_media_buy ACCOUNT_NOT_FOUND under proposal_finalize after AdCP 3.0.7 schema bump

[bokelley]

Summary

After the AdCP 3.0.7 schema bump (#1595, commit e772ac2) landed adcp#4088 — the storyboard fix that chains proposal_id from brief_with_proposals into refine / finalize / accept — the proposal_finalize storyboard now reaches accept_proposal/create_media_buy end-to-end. Previously the storyboard halted at refine_proposal (the gap tracked in #1549's allowlist as get_products_refine).

The newly-reachable create_media_buy step now fails:

✗ create_media_buy — Create media buy from proposal
    Response matches create-media-buy-response.json schema
    error: "ACCOUNT_NOT_FOUND: The specified account does not exist"

The hello_seller_adapter_proposal_mode adapter projects accounts.resolution: 'explicit'. Earlier phases (brief / refine / finalize) succeed, materializing the account. The create_media_buy request the storyboard sends includes account: { brand, operator, sandbox } (no account_id), and the mock-server's account lookup returns NOT_FOUND.

Reproduction

node --test test/examples/hello-seller-adapter-proposal-mode.test.js

(with EXPECTED_FAILURES = [] — currently held to get_products_refine which is now obsolete; #1596 drops the entry, which unmasks this issue.)

Expected

create_media_buy either:

• resolves the account by brand.domain + operator (matching how earlier proposal-mode phases materialized it), or
• the storyboard yaml chains account_id from a prior phase output via $context.account_id.

Either layer is in scope — needs triage to decide whether the SDK / mock-server / storyboard yaml owns the fix.

Workaround

#1596 adds this entry to EXPECTED_FAILURES in the proposal-mode CI gate so CI stays green; drop the allowlist entry once this issue lands.

Related

• Storyboard examples: add hello-seller-adapter-proposal-mode for sole-stateful-step coverage #1549 — sole-stateful exemption coverage (the test where this surfaces)
• chore(deps): bump AdCP 3.0.6 → 3.0.7 (closes #1586) #1595 / e772ac2 — AdCP 3.0.7 schema bump (revealed this)
• proposal_finalize.yaml: add context_outputs / context_inputs to chain proposal_id between steps adcp#4086 / adcp#4088 — upstream storyboard fix that unblocked the chain to create_media_buy

[bokelley]

Triage

Classification: Conformance failure — post-3.0.7 schema bump regression in proposal_finalize end-to-end path
Bucket(s): conformance (examples and cross-repo labels absent from repo — noted in run summary)
Status: ready-for-human

What the experts said:

• ad-tech-protocol-expert: Fix belongs in the storyboard yaml (adcontextprotocol/adcp) — add $context.account_id chaining into the create_media_buy step, the same pattern adcp#4088 used for proposal_id. Sending a fresh brand-ref on create_media_buy is protocol-legal but not idiomatic buyer behavior; the storyboard should model the idiomatic path. No SDK or mock-server change required.
• code-reviewer: Fix is in the example adapter — KNOWN_PUBLISHERS likely doesn't include the exact brand domain the 3.0.7 storyboard sends for create_media_buy, causing accounts.resolve to return null. Also flags a semantic mismatch: resolution: 'explicit' (line 225) is the wrong mode for a brand-only adapter; should be 'implicit'. Both are non-breaking, example-file-only changes.

My take: Experts split on layer — protocol expert says storyboard owns it (cross-repo adcontextprotocol/adcp), code reviewer says adapter owns it (this repo). Both may be correct simultaneously: the adapter has a latent resolution-mode mismatch AND the storyboard could chain account_id for protocol correctness. @bokelley — your call on sequencing: fix adapter (resolution: 'implicit' + KNOWN_PUBLISHERS) here first and file an upstream storyboard issue, or land the storyboard fix first to avoid the adapter change being rendered redundant?

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01DGsT9QpJwTY5pXHvAzfmKm

---

Generated by Claude Code

[bokelley]

Closing as duplicate of #1600 — the same root failure (post-3.0.7 create_media_buy schema validation) was filed and triaged via #1599. The ACCOUNT_NOT_FOUND error surfaced in my repro is the underlying cause of the schema-shape mismatch tracked in #1600; cross-posting the detail there.