Skip to content

feat(examples): hello_seller_adapter_proposal_mode cascade-scenario sandbox arm parity with guaranteed adapter #1605

@bokelley

Description

@bokelley

Context

examples/hello_seller_adapter_guaranteed.ts:591-608 has a cascade-scenario sandbox arm that handles the storyboard runner's resolved-sandbox-account case. The proposal-mode adapter (examples/hello_seller_adapter_proposal_mode.ts) lacks the equivalent arm.

Why deferred

Investigation under #1600 found that adding the sandbox arm doesn't actually help proposal-mode storyboards in isolation — the resolved sandbox account id wouldn't match the proposal store's expectedAccountId from prior phases (proposal registered under pub_acmeoutdoor.example). The real fix is the runner-enricher bug filed separately.

This issue is probably moot once that fix lands — leaving as a placeholder in case follow-up testing surfaces a residual gap.

Acceptance

  • After the runner enricher fix lands, re-run media_buy_seller/proposal_finalize storyboard against the proposal-mode adapter unfiltered.
  • If create_media_buy still fails on cascade-scenario account resolution, add the sandbox arm. Otherwise close as obsolete.

Refs

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions