decisioning: sync_accounts/list_accounts ship as _not_supported stubs (no wire dispatch)

[bokelley]

Problem

PlatformHandler in adcp 4.5.0 ships sync_accounts and list_accounts as _not_supported stubs:

async def sync_accounts(
    self, params: SyncAccountsRequest | dict[str, Any], context: TContext | None = None
) -> Any:
    """Sync accounts. Override this to provide functionality."""
    return self._not_supported("sync_accounts")

Compared to e.g. provide_performance_feedback in the same file:

async def provide_performance_feedback(
    self, params, context=None,
) -> ProvidePerformanceFeedbackResponse:
    tool_ctx = context or ToolContext()
    account = await self._resolve_account(None, tool_ctx)
    ctx = self._build_ctx(tool_ctx, account)
    return cast(..., await _invoke_platform_method(
        self._platform, "provide_performance_feedback", params, ctx,
        executor=self._executor, registry=self._registry,
    ))

The framework declares the spec request/response models (adcp.server.mcp_tools.ADCP_TOOL_DEFINITIONS includes sync_accounts + list_accounts), but never wires _invoke_platform_method for them. Result: an adopter that implements AccountStoreUpsert / AccountStoreList on their platform's accounts store is invisible on the wire — every call returns OPERATION_NOT_SUPPORTED.

Also affected: sync_governance (same _not_supported stub).

Repro

Implement AccountStoreUpsert.upsert on a platform's account store, run tools/list, observe sync_accounts is missing. Try to call it directly, get back the not-supported envelope.

Expected

PlatformHandler.sync_accounts should call self._platform.accounts.upsert(params, ctx) (forwarding to the AccountStore Protocol surface), and PlatformHandler.list_accounts should call self._platform.accounts.list(params, ctx). Same pattern as provide_performance_feedback, just routing through the account store instead of the platform method (because LazyPlatformRouter._ACCOUNT_STORE_METHODS correctly excludes account ops from per-tenant delegation).

get_advertised_tools should also include them — currently _SALES_ADVERTISED_TOOLS doesn't have either, so even with register_handler_tools they get stripped by the per-instance specialism filter (advertised_tools_for_instance).

Workaround

I've shipped a runtime polyfill in salesagent that:

1. Rebinds PlatformHandler.sync_accounts / list_accounts to call through to self._platform.accounts.upsert / .list (with _resolve_account(None, ctx) for auth-only resolution).
2. Mutates _HANDLER_TOOLS["PlatformHandler"] to add both tools.
3. Mutates every sales-* entry of SPECIALISM_TO_ADVERTISED_TOOLS to include both tools, so the per-instance filter doesn't strip them back out.

Code: https://github.com/bokelley/salesagent/blob/main/core/platforms/account_polyfill.py — happy to upstream as a PR if direction is agreed.

Why it matters

Sellers MUST expose either list_accounts or sync_accounts per the spec. Adopters implementing the protocol correctly find their compliance score blocked by what looks like a one-line framework oversight — _not_supported instead of _invoke_platform_method. Storyboard validators silently skip those scenarios under missing_tool, masking the gap (see #1623, #1624 for the related skip-vs-fail framing).

Tracked downstream: bokelley/salesagent commit 4e62024c.

[bokelley]

Triage

Classification: needs-info
Bucket(s): (no clear match — see note below)
Status: clarify

What the experts said:

• code-reviewer: TypeScript dispatch is intact — buildAccountHandlers (from-platform.ts:4554–4591) correctly wires sync_accounts→accounts.upsert, list_accounts→accounts.list, sync_governance→accounts.syncGovernance; the Python symbols in the workaround (_HANDLER_TOOLS, SPECIALISM_TO_ADVERTISED_TOOLS, PlatformHandler, async def) have no TypeScript equivalents in this codebase.
• ad-tech-protocol-expert: "adcp 4.5.0" maps to neither the TypeScript library version (v6.x) nor the AdCP wire spec version (3.0.x); docs/proposals/decisioning-platform-python-port-v2.md confirms a separate Python adcp-client with the PlatformHandler class-based dispatch model the workaround targets.

My take: The workaround is a .py file mutating Python dispatch tables that don't exist in the TypeScript @adcp/sdk. The TypeScript SDK already dispatches sync_accounts/list_accounts/sync_governance through the optional AccountStore.upsert?/list?/syncGovernance? hooks — the bug described doesn't appear to be present here. This looks like it may be filed against the wrong tracker.

1. Is this about the Python adcp-client / adcontextprotocol/salesagent rather than the TypeScript @adcp/sdk? If so, the bug should be filed there.
2. If this IS about TypeScript: can you share a repro? With @adcp/sdk 6.x, implementing accounts.upsert on a DecisioningPlatform should cause sync_accounts to appear in MCP tools/list without any polyfill.

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01EENjYc6Fn6d8PfbJ7weEKe

---

Generated by Claude Code

[bokelley]

Python equivalent shipped: adcontextprotocol/adcp-client-python#609 — wires the dispatchers through the AccountStore Protocols, adds positive + negative tests. (TypeScript SDK still needs the equivalent if/when sync_accounts/list_accounts dispatch is added there.)

[bokelley]

Triage

Classification: bug (Python-side; TypeScript unaffected)
Bucket(s): cross-repo
Status: not-actionable

What the experts found:

• code-reviewer (prior run, re-verified): buildAccountHandlers in src/lib/server/decisioning/runtime/from-platform.ts:4554–4591 gates on accounts.upsert / accounts.list presence and wires sync_accounts / list_accounts dispatch when the adopter implements them — no stub, no polyfill required.

My take: Python side is resolved via adcontextprotocol/adcp-client-python#609. The TypeScript @adcp/sdk has dispatched sync_accounts/list_accounts through the AccountStore Protocol since the decisioning runtime shipped — buildAccountHandlers wires both, gated on accounts.upsert/accounts.list presence, so an adopter implementing those methods gets live dispatch automatically. The "TypeScript SDK still needs the equivalent" note in the latest comment doesn't apply; this issue can be closed.

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01TAXdTpMCHRk3vvBhGUC9LJ

---

Generated by Claude Code

[bokelley]

Closing — the TypeScript SDK already wires sync_accounts/list_accounts dispatch through AccountStore correctly. See buildAccountHandlers in src/lib/server/decisioning/runtime/from-platform.ts:4554–4591: both handlers are wired conditionally on accounts.upsert / accounts.list presence — no _not_supported stub, no polyfill needed for adopters who implement those methods.

The original report tracked the Python-side gap (adcp-client-python, fixed in adcontextprotocol/adcp-client-python#609). No work needed on the TS side.

If a TS adopter is seeing OPERATION_NOT_SUPPORTED on those tools, open a fresh issue with a repro — most likely cause is missing .upsert/.list on the AccountStore Protocol surface, not a framework gap.