Fix from_serialized

Author: edan-bainglass

src/aiida/orm/entities.py

@@ -376,9 +376,10 @@ def serialize(
         ).model_dump(mode=mode)
 
     @classmethod
-    def from_serialized(cls, unstored: bool = False, **kwargs: dict[str, Any]) -> Self:
+    def from_serialized(cls, serialized: dict[str, Any], unstored: bool = False) -> Self:
         """Construct an entity instance from JSON serialized data.
 
+        :param serialized: A dictionary representing the serialized entity.
         :param unstored: If True, the input version of the model is used, which strips read-only fields, i.e., fields
             with `exclude_to_orm=True`.
         :return: An instance of the entity class.
@@ -387,7 +388,7 @@ def from_serialized(cls, unstored: bool = False, **kwargs: dict[str, Any]) -> Se
             'Serialization through pydantic is still an experimental feature and might break in future releases.'
         )
         Model = cls.InputModel if unstored else cls.Model  # noqa: N806
-        return cls.from_model(Model(**kwargs))
+        return cls.from_model(Model(**serialized))
 
     @classproperty
     def objects(cls: EntityType) -> CollectionType:  # noqa: N805

tests/orm/data/code/test_abstract.py

@@ -72,4 +72,4 @@ def test_serialization():
     label = 'some-label'
     code = MockCode(label=label)
 
-    MockCode.from_serialized(unstored=True, **code.serialize(unstored=True))
+    MockCode.from_serialized(code.serialize(unstored=True), unstored=True)

tests/orm/data/code/test_installed.py

@@ -152,4 +152,4 @@ def test_serialization(aiida_localhost, bash_path):
     """Test the deprecated :meth:`aiida.orm.nodes.data.code.installed.InstalledCode.get_execname` method."""
     code = InstalledCode(label='some-label', computer=aiida_localhost, filepath_executable=str(bash_path.absolute()))
 
-    InstalledCode.from_serialized(unstored=True, **code.serialize(unstored=True))
+    InstalledCode.from_serialized(code.serialize(unstored=True), unstored=True)

tests/orm/data/code/test_portable.py

@@ -176,4 +176,4 @@ def test_serialization(tmp_path, chdir_tmp_path):
     (filepath_files / 'subdir').mkdir()
     (filepath_files / 'subdir/test').write_text('test')
     code = PortableCode(label='some-label', filepath_executable='bash', filepath_files=filepath_files)
-    PortableCode.from_serialized(unstored=True, **code.serialize(unstored=True))
+    PortableCode.from_serialized(code.serialize(unstored=True), unstored=True)

tests/orm/models/test_models.py

@@ -214,4 +214,4 @@ def test_roundtrip_serialization(required_arguments, tmp_path):
 
     # Get the model instance from the entity instance
     serialized_entity = entity.serialize(repository_path=tmp_path, unstored=True, mode='python')
-    entity.from_serialized(unstored=True, **serialized_entity)
+    entity.from_serialized(serialized_entity, unstored=True)