Hi ailon,
In lines 235-238: Why don't you just simly write...
result.CanonicalManufacturer = manufacturer;
...?
And in line 219:
CanonicalManufacturer = manufacturer,
From the switch/case statement in lines 25-26, the variable "manufacturer" is always filled with the respective manufacturer name (either Nokia or Microsoft). This would make the code easier and would also prevent an implementation of redundant Information, such as "CanonicalManufacturer="MICROSOFT" (see lines 522-525).
What do you think?
Best regards,
Patrick
Hi ailon,
In lines 235-238: Why don't you just simly write...
result.CanonicalManufacturer = manufacturer;
...?
And in line 219:
CanonicalManufacturer = manufacturer,
From the switch/case statement in lines 25-26, the variable "manufacturer" is always filled with the respective manufacturer name (either Nokia or Microsoft). This would make the code easier and would also prevent an implementation of redundant Information, such as "CanonicalManufacturer="MICROSOFT" (see lines 522-525).
What do you think?
Best regards,
Patrick