Skip to content

Commit 8abcbbe

Browse files
committed
fix: account picker toggle props handling + types
1 parent 8bfcbf8 commit 8abcbbe

File tree

4 files changed

+20
-7
lines changed

4 files changed

+20
-7
lines changed

src/components/modules/AccountPicker/AccountInformation/cmp.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export const AccountInformation = ({
1818
rewards,
1919
accountAddress,
2020
accountAddressHref,
21+
showExternalUrl,
2122
externalUrl,
2223
disabledTopUp,
2324
handleTopUpClick,
@@ -140,8 +141,17 @@ export const AccountInformation = ({
140141
</>
141142
)}
142143

143-
<StyledLine />
144-
<ExternalUrl Link={Link} text={externalUrl.text} url={externalUrl.url} />
144+
{showExternalUrl && externalUrl && (
145+
<>
146+
<StyledLine />
147+
148+
<ExternalUrl
149+
Link={Link}
150+
text={externalUrl.text}
151+
url={externalUrl.url}
152+
/>
153+
</>
154+
)}
145155
</>
146156
)
147157
}

src/components/modules/AccountPicker/AccountInformation/types.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ export type AccountInformationProps = {
2121
vouchers?: Voucher[]
2222
disabledTopUp?: boolean
2323
handleTopUpClick?: () => void
24-
externalUrl: {
24+
showExternalUrl: boolean
25+
externalUrl?: {
2526
text: string
2627
url: string
2728
}

src/components/modules/AccountPicker/cmp.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ export const AccountPicker = ({
166166
vouchers={accountVouchers}
167167
disabledTopUp={disabledTopUp}
168168
handleTopUpClick={handleTopUpClick}
169+
showExternalUrl={showExternalUrl}
169170
externalUrl={externalUrl}
170171
Link={Link}
171172
/>
@@ -178,7 +179,7 @@ export const AccountPicker = ({
178179
onDisconnect={handleDisconnect}
179180
selectedNetwork={selectedNetwork}
180181
/>
181-
{!isConnected && showExternalUrl && (
182+
{!isConnected && showExternalUrl && externalUrl && (
182183
<>
183184
<StyledLine />
184185
<ExternalUrl
@@ -238,6 +239,7 @@ export const AccountPicker = ({
238239
vouchers={accountVouchers}
239240
disabledTopUp={disabledTopUp}
240241
handleTopUpClick={handleTopUpClick}
242+
showExternalUrl={showExternalUrl}
241243
externalUrl={externalUrl}
242244
Link={Link}
243245
/>
@@ -252,7 +254,7 @@ export const AccountPicker = ({
252254
onDisconnect={handleDisconnect}
253255
selectedNetwork={selectedNetwork}
254256
/>
255-
{!isConnected && showExternalUrl && (
257+
{!isConnected && showExternalUrl && externalUrl && (
256258
<>
257259
<StyledLine />
258260
<ExternalUrl

src/components/modules/AccountPicker/types.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ export type AccountPickerProps = {
3232
selectedNetwork: Network
3333
disabledTopUp?: boolean
3434
handleTopUpClick?: () => void
35-
externalUrl: {
35+
externalUrl?: {
3636
text: string
3737
url: string
3838
}
39-
settingsContent: ReactNode
39+
settingsContent?: ReactNode
4040
handleSwitchNetwork: NetworkSelectorProps['onSelectNetwork']
4141
handleConnect: (wallet: Wallet, network: Network) => void
4242
handleDisconnect: () => void

0 commit comments

Comments
 (0)